Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -448,9 +448,17 @@ private void processDependency( Args args, Results results, DependencyProcessing
context.getParent().getChildren().add( child );

boolean recurse = traverse && !descriptorResult.getDependencies().isEmpty();
DependencyProcessingContext parentContext = context.withDependency( d );
if ( recurse )
{
doRecurse( args, context.withDependency( d ), descriptorResult, child );
doRecurse( args, parentContext, descriptorResult, child );
}
else if ( !args.skipper.skipResolution( child, parentContext.parents ) )
{
List<DependencyNode> parents = new ArrayList<>( parentContext.parents.size() + 1 );
parents.addAll( parentContext.parents );
parents.add( child );
args.skipper.cache( child, parents );
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@
import org.eclipse.aether.util.graph.manager.DefaultDependencyManager;
import org.eclipse.aether.util.graph.manager.DependencyManagerUtils;
import org.eclipse.aether.util.graph.manager.TransitiveDependencyManager;
import org.eclipse.aether.util.graph.transformer.ConflictResolver;
import org.eclipse.aether.util.graph.transformer.JavaScopeDeriver;
import org.eclipse.aether.util.graph.transformer.JavaScopeSelector;
import org.eclipse.aether.util.graph.transformer.NearestVersionSelector;
import org.eclipse.aether.util.graph.transformer.SimpleOptionalitySelector;
import org.eclipse.aether.util.graph.version.HighestVersionFilter;
import org.junit.Before;
import org.junit.Test;
Expand Down Expand Up @@ -576,6 +581,26 @@ public void testVersionFilter()
assertEquals( 1, result.getRoot().getChildren().size() );
}


@Test
public void testDescriptorDependenciesEmpty()
throws Exception
{
DependencyNode root = parser.parseResource("expectedSubtreeOnDescriptorDependenciesEmpty.txt");
Dependency dependency = root.getDependency();
CollectRequest request = new CollectRequest(dependency, Arrays.asList(repository));

collector.setArtifactDescriptorReader(newReader("dependencies-empty/"));

session.setDependencyGraphTransformer(new ConflictResolver(
new NearestVersionSelector(), new JavaScopeSelector(), new SimpleOptionalitySelector(),
new JavaScopeDeriver()
));

CollectResult result = collector.collectDependencies(session, request);
assertEqualSubtree(root, result.getRoot());
}

static class TestDependencyManager
implements DependencyManager
{
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[dependencies]
gid:b:jar:ver
gid:c:jar:ver
gid:e:jar:ver
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[dependencies]
gid:d:jar:1
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[dependencies]
gid:d:jar:2
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[dependencies]
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[dependencies]
gid:g:jar:1
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[dependencies]
gid:f:jar:ver
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[dependencies]
gid:g:jar:2
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[dependencies]
gid:h:jar:1
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[dependencies]
gid:h:jar:2
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[dependencies]
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[dependencies]
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
gid:a:jar:ver
+- gid:b:jar:ver compile
| \- gid:d:jar:1 compile
+- gid:c:jar:ver compile
\- gid:e:jar:ver compile
| +- gid:f:jar:ver compile
| | +- gid:g:jar:2 compile
| | | \- gid:h:jar:2 compile