Add some TLP doco about shared local repo access#185
Merged
Conversation
Member
Author
|
@kwin ping |
Member
|
Thanks looks good to me, can you also update https://maven.apache.org/resolver/maven-resolver-named-locks/index.html in this PR based on #184 as I think you guys know best how to clarify the doc with regards to |
kwin
reviewed
Jun 22, 2022
| Local named locks are only suited within one JVM with a multithreaded build. | ||
| Sharing a local repository between multiple Maven processes (i.e., on a busy CI server) requires a distributed named lock! | ||
| Sharing a local repository between multiple hosts (i.e., on a busy CI server) requires a distributed named lock! | ||
|
|
Member
There was a problem hiding this comment.
Maybe the example CI server is not the best as I don’t know of any tools which recommend or ease setting up a shared Maven repo used by distributed nodes…
Member
Author
There was a problem hiding this comment.
Agreed, but that's actually the point as well: they do not recommend as Maven had issues with it before resolver 1.7 😉
Member
Author
Member
|
Will review today... |
michael-o
requested changes
Jun 24, 2022
michael-o
approved these changes
Jun 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework local repo page available from TLP, move "uninteresting" simple LRM to bottom, add intro about locking, to not have it buried in some module...
Inspired by #184