Skip to content

[MRESOLVER-265] Checksum of checksum#187

Merged
cstamas merged 1 commit intomasterfrom
MRESOLVER-265-checksum-of-checksum
Jun 24, 2022
Merged

[MRESOLVER-265] Checksum of checksum#187
cstamas merged 1 commit intomasterfrom
MRESOLVER-265-checksum-of-checksum

Conversation

@cstamas
Copy link
Copy Markdown
Member

@cstamas cstamas commented Jun 24, 2022

There is a discrepancy when a checksum is attached (so not added
by resolver itself), and resolver will checksum it if the algorithm
is not configured (ie. default config used but SHA512 added).

This makes it work as expected, as checksum recognition works
now against ALL SUPPORTED and not configured ONLY checksums).


https://issues.apache.org/jira/browse/MRESOLVER-265

There is a discrepancy when a checksum is attached (so not added
by resolver itself), and resolver will checksum it if the algorithm
is not configured (ie. default config used but SHA512 added).

This makes it work as expected, as checksum recognition works
now against ALL SUPPORTED and not configured ONLY checksums).
@cstamas cstamas self-assigned this Jun 24, 2022
@cstamas cstamas requested a review from michael-o June 24, 2022 08:46
@kwin
Copy link
Copy Markdown
Member

kwin commented Jun 24, 2022

I am pretty sure some older Maven repository implementations (e.g. Nexus2) always require MD5/SHA1 (even for sha512 files). Not sure about the implications of this change with those repo managers.

@cstamas
Copy link
Copy Markdown
Member Author

cstamas commented Jun 24, 2022

I am pretty sure some older Maven repository implementations (e.g. Nexus2) always require MD5/SHA1 (even for sha512 files). Not sure about the implications of this change with those repo managers.

I am pretty sure this is not true for deploy (to some hosted repository), is it possible you talk about staging maybe? As in that case, Nexus2 (on repo.a.o but also OSS.s.o) enforce some things, and yes, I'd expect some strangeness here.... but given it's closed source, they should fix it IMHO 😄

@kwin
Copy link
Copy Markdown
Member

kwin commented Jun 24, 2022

These are the staging rule conflicts I am aware of: https://issues.apache.org/jira/browse/INFRA-14923 and https://issues.sonatype.org/browse/MVNCENTRAL-5276

@cstamas
Copy link
Copy Markdown
Member Author

cstamas commented Jun 24, 2022

Seems https://issues.sonatype.org/browse/NEXUS-21802 is fixed in Nx2 2.14.18, and ASF NX2 is 2.14.20 and oss.s.o is 2.15 so both should be fine.

@cstamas cstamas merged commit f251fdc into master Jun 24, 2022
@cstamas cstamas deleted the MRESOLVER-265-checksum-of-checksum branch June 24, 2022 19:18
@jira-importer
Copy link
Copy Markdown

Resolve #758

1 similar comment
@jira-importer
Copy link
Copy Markdown

Resolve #758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants