[MRESOLVER-278] Session close and onClose hooks#201
Merged
cstamas merged 5 commits intoapache:masterfrom Oct 14, 2022
Merged
Conversation
This was referenced Oct 11, 2022
cstamas
force-pushed
the
session-close-itself
branch
from
801995c to
fee3994
Compare
cstamas
changed the title
cstamas
force-pushed
the
session-close-itself
branch
from
dcd01a3 to
532aba5
Compare
Make session have close() method, denoting that given session instance is "done". This is integrator app obligation ot invoke this method. Also introdue onClose callbacks, that various components may use to hook when session is marked "done" to perform various cleanups. --- https://issues.apache.org/jira/browse/MRESOLVER-278
cstamas
force-pushed
the
session-close-itself
branch
from
532aba5 to
393b2a7
Compare
gnodet
requested changes
Oct 13, 2022
gnodet
approved these changes
Oct 14, 2022
michael-o
requested changes
Oct 14, 2022
Member
michael-o
left a comment
michael-o
left a comment
There was a problem hiding this comment.
Not bad after all, but I'd like to have the Maven intergration to test with Redisson as well thoroughly.
|
Resolve #954 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make session extend
AutoCloseable, denoting that givensession instance is "done". This is integrator app
obligation to close the "done" session.
Also introdue onClose callbacks, that various components
may use to hook when session is marked "done" to
perform various cleanups.
https://issues.apache.org/jira/browse/MRESOLVER-278