[MRESOLVER-278] Session close and onClose hooks fix#207
Merged
cstamas merged 2 commits intoapache:masterfrom Oct 26, 2022
Merged
[MRESOLVER-278] Session close and onClose hooks fix#207cstamas merged 2 commits intoapache:masterfrom
cstamas merged 2 commits intoapache:masterfrom
Conversation
There are valid cases in Maven when interaction with resolver (that would "lazily" init SyncContext) happens way late, when session is already done readOnly. Fix: adding onCloseHandler should NOT be affected by readOnly state of session, as it merely means it's members like LRM, etc are "fixed", but session data etc are all still mutable. Similarly, due lazy init, some components may way -- as above in valid cases -- register some handler when session is already read only. This change makes all Maven ITs pass with this resolver.
michael-o
requested changes
Oct 26, 2022
michael-o
approved these changes
Oct 26, 2022
|
Resolve #954 |
1 similar comment
|
Resolve #954 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maven ITs running against apache/maven#831 fails. Reason is "too late" registration of onClose handler to session, when it is already readOnoy.
There are valid cases in Maven when interaction with resolver (that would "lazily" init SyncContext) happens way late, when session is already made readOnly.
Fix: adding onCloseHandler should NOT be affected by readOnly state of session, as it merely means it's members like LRM, etc are "fixed", but session data etc are all still mutable.
Similarly, due lazy init, some components may -- as in above valid cases -- register some handler when session is already read only.
This change makes all Maven ITs pass with this resolver.