[MNG-6829] refactor: Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)#169
Conversation
…otEmpty(String) ### [Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)](https://public.moderne.io/recipes/org.openrewrite.java.migrate.apache.commons.lang.IsNotEmptyToJdk) A continuation of https://issues.apache.org/jira/browse/MNG-6825 and https://issues.apache.org/jira/browse/MNG-6829, where previously a request was made to instead of switching implementation to a different StringUtils, we should instead switch to using JDK internals where we can. This is a first such pull request to gauge interest before I can potentially make 47 more PRs to replace a total of 210 uses of isEmpty / isNotEmpty. Co-authored-by: Moderne <team@moderne.io>
|
@slachiewicz This is a continuation of #168 ; now aimed at reducing the reliance on There's a few unfortunate patterns in the repository where previously |
|
@elharo Here's a previous one that we could merge now that the CCLA has been signed, unless you want me to tackle the ! inversion first. |
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
Github is acting up and won't let me merge. I'll try later.
timtebeek
deleted the
refactor/replace-any-string-utils-is-empty-string-and-is-not-empty-string
branch
2 participants
Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)
A continuation of https://issues.apache.org/jira/browse/MNG-6825 and https://issues.apache.org/jira/browse/MNG-6829, where previously a request was made to instead of switching implementation to a different StringUtils, we should instead switch to using JDK internals where we can. This is a first such pull request to gauge interest before I can potentially make 47 more PRs to replace a total of 210 uses of isEmpty / isNotEmpty.