[MNG-6847] Use diamond operator#184
Merged
slachiewicz merged 1 commit intoapache:masterfrom Aug 19, 2023
Merged
Conversation
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu Co-authored-by: Moderne <team@moderne.io>
slachiewicz
approved these changes
Aug 19, 2023
Contributor
Author
|
Thanks for the quick review @slachiewicz ; Would you be ok with me opening let's say six more starting from the top? |
Member
|
Yes, sure. Thx fro help |
This was referenced Aug 19, 2023
Contributor
Author
|
Happy to help! I've opened a few more, all linked above, some of which need approval for the pipelines to run. Open to other systems as well; there's a long tail of 1 or 2 cases per repository that might not make sense by itself. |
This was referenced Aug 19, 2023
timtebeek
added a commit
to timtebeek/maven-doxia-book-renderer
that referenced
this pull request
Aug 20, 2023
As discussed on - apache/maven-scm#184 - https://issues.apache.org/jira/browse/MNG-6847 Review requested of @elharo Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu Co-authored-by: Moderne <team@moderne.io>
timtebeek
added a commit
to timtebeek/maven-site-plugin
that referenced
this pull request
Aug 20, 2023
As discussed on - apache/maven-scm#184 - https://issues.apache.org/jira/browse/MNG-6847 Review requested of @elharo Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu Co-authored-by: Moderne <team@moderne.io>
timtebeek
added a commit
to timtebeek/maven-dependency-plugin
that referenced
this pull request
Aug 20, 2023
As discussed on - apache/maven-scm#184 - https://issues.apache.org/jira/browse/MNG-6847 Review requested of @elharo Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu Co-authored-by: Moderne <team@moderne.io>
timtebeek
added a commit
to timtebeek/maven-ejb-plugin
that referenced
this pull request
Aug 20, 2023
As discussed on - apache/maven-scm#184 - https://issues.apache.org/jira/browse/MNG-6847 Review requested of @elharo Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu Co-authored-by: Moderne <team@moderne.io>
timtebeek
added a commit
to timtebeek/maven-resolver
that referenced
this pull request
Aug 20, 2023
As discussed on - apache/maven-scm#184 - https://issues.apache.org/jira/browse/MNG-6847 Review requested of @elharo Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu Co-authored-by: Moderne <team@moderne.io>
This was referenced Aug 20, 2023
timtebeek
added a commit
to timtebeek/maven-ejb-plugin
that referenced
this pull request
Aug 20, 2023
As discussed on - apache/maven-scm#184 - https://issues.apache.org/jira/browse/MNG-6847 Review requested of @elharo Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu Co-authored-by: Moderne <team@moderne.io>
This was referenced Aug 20, 2023
timtebeek
added a commit
to timtebeek/maven-resolver
that referenced
this pull request
Aug 20, 2023
As discussed on - apache/maven-scm#184 - https://issues.apache.org/jira/browse/MNG-6847 Review requested of @elharo Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu Co-authored-by: Moderne <team@moderne.io>
elharo
pushed a commit
to apache/maven-resolver
that referenced
this pull request
Aug 29, 2023
As discussed on - apache/maven-scm#184 - https://issues.apache.org/jira/browse/MNG-6847 Review requested of @elharo Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu Co-authored-by: Moderne <team@moderne.io>
elharo
pushed a commit
to apache/maven-ejb-plugin
that referenced
this pull request
Aug 29, 2023
As discussed on - apache/maven-scm#184 - https://issues.apache.org/jira/browse/MNG-6847 Review requested of @elharo Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu Co-authored-by: Moderne <team@moderne.io>
elharo
pushed a commit
to apache/maven-site-plugin
that referenced
this pull request
Aug 29, 2023
As discussed on - apache/maven-scm#184 - https://issues.apache.org/jira/browse/MNG-6847 Review requested of @elharo Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu Co-authored-by: Moderne <team@moderne.io>
elharo
pushed a commit
to apache/maven-doxia-book-renderer
that referenced
this pull request
Aug 29, 2023
As discussed on - apache/maven-scm#184 - https://issues.apache.org/jira/browse/MNG-6847 Review requested of @elharo Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu Co-authored-by: Moderne <team@moderne.io>
slachiewicz
pushed a commit
to apache/maven-dependency-plugin
that referenced
this pull request
Sep 13, 2023
As discussed on - apache/maven-scm#184 - https://issues.apache.org/jira/browse/MNG-6847 Review requested of @elharo Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu Co-authored-by: Moderne <team@moderne.io>
michael-o
pushed a commit
to apache/maven-site-plugin
that referenced
this pull request
Jul 20, 2024
As discussed on - apache/maven-scm#184 - https://issues.apache.org/jira/browse/MNG-6847 Review requested of @elharo Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu Co-authored-by: Moderne <team@moderne.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Found MNG-6847 on the backlog (closed), but that had only been applied to apache/maven#315 itself, not the additional 36 projects that could still use those changes. Figured open this one as a first one to ask if you'd appreciate any more.
These PRs are trivial for me to create, but I would not want to cause any review burden. That's why I'm only starting with one, and not creating more unless I get a positive response here.
Here's a full list of projects that could still use these changes.
@elharo would this be something you're willing to review as well? Welcome to direct me to others too.
For my future self and others; Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu