[MSHADE-478] Extra JARs feature #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ability to add "extra JARs" and still enjoy the full benefits of relocation, resource transformation, etc. --- https://issues.apache.org/jira/browse/MSHADE-478
| if (extraJars != null && !extraJars.isEmpty()) { | ||
| for (File extraJar : extraJars) { | ||
| if (!Files.isRegularFile(extraJar.toPath())) { | ||
| createErrorOutput(); |
Member
There was a problem hiding this comment.
Please check if this error message are correct here 😄
Member
There was a problem hiding this comment.
private void createErrorOutput() {
getLog().error("The project main artifact does not exist. This could have the following");
getLog().error("reasons:");
....
slawekjaranowski
approved these changes
May 28, 2024
slawekjaranowski
approved these changes
May 28, 2024
|
Resolve #675 |
1 similar comment
|
Resolve #675 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to add "extra JARs and Artifacts" and still enjoy the full benefits of relocation, resource transformation, etc.
https://issues.apache.org/jira/browse/MSHADE-478