[MPLUGINTESTING-93] Documentation for Plugin testing#597
[MPLUGINTESTING-93] Documentation for Plugin testing#597aamotharald wants to merge 13 commits intoapache:masterfrom
Conversation
Bukama
left a comment
Bukama
left a comment
There was a problem hiding this comment.
Thanks for the migration. Got some comments, you may want to consider.
P.S. I personally prefer to write only one sentence per line in a documentation as code file, but I don't know if maven has clear rules about this.
elharo
changed the title
|
Thanks @slawekjaranowski @elharo and @Bukama for your review! I learned a lot and was able to address your review comments with (for me) sound solutions. |
|
|
||
| ### Using PlexusTestCase | ||
|
|
||
| Mojo variables are injected by Guice (an open-source software framework for the Java platform), sometimes with a Codehaus Plexus (a collection of components used by Apache Maven) adapter to support the legacy `@Component` annotation. |
There was a problem hiding this comment.
delete "to support the legacy @Component annotation."
I've eliminated all of those
|
Can't add anything to what @elharo has already mentioned. |
|
|
||
| ### Using PlexusTestCase | ||
|
|
||
| Mojo variables are injected by Guice (an open-source software framework for the Java platform), sometimes with a Codehaus Plexus (a collection of components used by Apache Maven) adapter. |
There was a problem hiding this comment.
delete "(an open-source software framework for the Java platform)" as it doesn't add much. Folks can Google it if they've never heard of it
There was a problem hiding this comment.
and might as wellm delete "(a collection of components used by Apache Maven)" too
|
Thanks for work ... By the way I would like to have such documentation in project in branch 3.x I'm still think that release of 3.4.0 - maven-plugin-testing should be done ... on my list 😄 |
|
@aamotharald Sorry for the long time not responding. We are still interested in the changes of your PR. Would you refresh it (put in last comments and resolve conflicts) :) |
|
@aamotharald thanks for the effort, we have done similar updates in: so I close it |
4 participants
Added Docu on how to test with JUnit5.
Converted the Docu from apt to md .
This PR should only get merged once org.apache.maven.plugin-testing:maven-plugin-testing-harness:3.4.0 has been released as on 3.3.0 there is no JUnit5 testing support at all.