Fixes #3264 : tests inside @Suite incorrectly classified as flakes#3342
Open
mirkoalicastro wants to merge 1 commit intoapache:masterfrom
Open
Fixes #3264 : tests inside @Suite incorrectly classified as flakes#3342mirkoalicastro wants to merge 1 commit intoapache:masterfrom
mirkoalicastro wants to merge 1 commit intoapache:masterfrom
Conversation
fabffc2 to
878db1d
Compare
Author
|
Hi @olamy , any chance you could have a look at this? 🙏 |
Author
|
@olamy it looks that there are some failures - unrelated to the changes. Would it be fine to proceed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
rerunFailingTestsCountis used with JUnit Platform@Suite, tests from different classes that share a method name are merged under the Suite class name. It causes real failures to be misclassified as flakes. With the changes in the PR,findTopParent()now stops at engine boundaries (parents with noClassSource), correctly attributing tests to their actual class while preserving@Nested.Following this checklist to help us incorporate your contribution quickly and easily:
mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.