Add some javadoc and unit tests to includesFile and excludesFile

[imonteroperez]

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean install to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[Tibor17]

Hi @imonteroperez ,

Now pls Cherry-pick mine commit and then let's work on the unit tests. We can mix those parts together in your PR.

[imonteroperez]

@Tibor17 I added the pending unit tests. I would propose you to review and merge this to your opened PR #440

[Tibor17]

@imonteroperez
That's pity that you made the unit tests in the module maven-surefire-plugin and not in maven-surefire-common. The ASM class is in maven-surefire-common. The coverage cannot be measured across modules.

[imonteroperez]

@imonteroperez That's pity that you made the unit tests in the module maven-surefire-plugin and not in maven-surefire-common. The ASM class is in maven-surefire-common. The coverage cannot be measured across modules.

Although the ASM class is in the maven-surefire-common module, the surefire.includesFile/excludesFile are provided at SurefirePlugin on maven-surefire-plugin, so I considered (probably wrong, this is my first contribution to the project) that this should be the right place. WDYT?

[olamy]

@imonteroperez That's pity that you made the unit tests in the module maven-surefire-plugin and not in maven-surefire-common. The ASM class is in maven-surefire-common. The coverage cannot be measured across modules.

jacoco reports are merged in Jenkins reports.
So the coverage should be fine accros modules?

[Tibor17]

@imonteroperez
Thank you very much for all your efforts. I appreciate it.
I will cherry pick it to mine branch and check the module target.

[Tibor17]

@imonteroperez
I am working on it.

[Tibor17]

Closed. We continue in #440 .