Skip to content

[MVERIFIER-38] Define encoding for FileReader#2

Closed
KroArtem wants to merge 2 commits intoapache:masterfrom
KroArtem:MVERIFIER-38-define-encoding
Closed

[MVERIFIER-38] Define encoding for FileReader#2
KroArtem wants to merge 2 commits intoapache:masterfrom
KroArtem:MVERIFIER-38-define-encoding

Conversation

@KroArtem
Copy link
Copy Markdown
Contributor

After discussions in #1 and in mailing list, I've looked at maven-its project and modello and it's not clear how to replace this plugin there. Thus I've decided to fix this small issue, update dependencies and (probably?) ask for a release.

After that this plugin can be retired. @slachiewicz , WDYT?

If you provide any ideas how to replace usages in repos mentioned above, I can do this as well. (Currently I just don't have enough knowledge about existing tools)

@KroArtem
Copy link
Copy Markdown
Contributor Author

@slachiewicz, ping

@KroArtem
Copy link
Copy Markdown
Contributor Author

@slachiewicz, ping again 😃

@slachiewicz
Copy link
Copy Markdown
Member

Thx for reminder - please look for discussion on maven-dev mailing list

@michael-o
Copy link
Copy Markdown
Member

Why not use source encoding defined in the POM?

@KroArtem
Copy link
Copy Markdown
Contributor Author

@slachiewicz , there was no reaction except yours. As I have wrote in this PR, this plugin is used in two places and it is not clear how to replace it there. That's why I decided it's a good idea to fix these issues, release a new version and retire plugin.

@KroArtem
Copy link
Copy Markdown
Contributor Author

@michael-o , I've missed your comment back then :(

I've also defined encoding in pom.xml but we also discussed FileReader here: #1 (comment)

I still think a new version could be released, then call plugin retired and then create issues to replace this plugin from maven-its project and modello.

@slachiewicz, wdyt?

@KroArtem
Copy link
Copy Markdown
Contributor Author

I guess this is outdated and should be closed.

@KroArtem KroArtem closed this Jan 27, 2022
@jira-importer
Copy link
Copy Markdown

Resolve #38

1 similar comment
@jira-importer
Copy link
Copy Markdown

Resolve #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants