[MVERIFIER-38] Define encoding for FileReader#2
[MVERIFIER-38] Define encoding for FileReader#2KroArtem wants to merge 2 commits intoapache:masterfrom
Conversation
|
@slachiewicz, ping |
|
@slachiewicz, ping again 😃 |
|
Thx for reminder - please look for discussion on maven-dev mailing list |
|
Why not use source encoding defined in the POM? |
|
@slachiewicz , there was no reaction except yours. As I have wrote in this PR, this plugin is used in two places and it is not clear how to replace it there. That's why I decided it's a good idea to fix these issues, release a new version and retire plugin. |
|
@michael-o , I've missed your comment back then :( I've also defined encoding in pom.xml but we also discussed FileReader here: #1 (comment) I still think a new version could be released, then call plugin retired and then create issues to replace this plugin from @slachiewicz, wdyt? |
|
I guess this is outdated and should be closed. |
|
Resolve #38 |
1 similar comment
|
Resolve #38 |
After discussions in #1 and in mailing list, I've looked at
maven-itsproject andmodelloand it's not clear how to replace this plugin there. Thus I've decided to fix this small issue, update dependencies and (probably?) ask for a release.After that this plugin can be retired. @slachiewicz , WDYT?
If you provide any ideas how to replace usages in repos mentioned above, I can do this as well. (Currently I just don't have enough knowledge about existing tools)