Regression: webResources are not included

[JimmyAx]

Affected version

3.5.0

Bug description

Starting with the release of version 3.5.0 my Maven project will not copy webResources into the created war file. I have created an integration test reproducing the issue that can be found at JimmyAx@8dbd31b It tries to include another.jsp into the created war file. It works fine for 3.4.0 but is failing for 3.5.0.

With a git bisect I managed to narrow it down to 95ab859 being the commit that introduced the issue. I believe that AbstractWarPackagingTask.isExcluded is not working as intended. It's ending up in the last return true which will cause another.jsp to be excluded from the created war file rather than included as it previously was.

[pzygielo]

Adding explicitly what is in linked IT's build.log:

[INFO] Processing war project
[INFO] Copying webapp webResources [/tmp/maven-war-plugin/target/it/war-resources/src/main/extra] to [/tmp/maven-war-plugin/target/it/war-resources/target/war-resources-1.0-SNAPSHOT]
[DEBUG] Skipping excluded file: //another.jsp
[INFO] Copying webapp resources [/tmp/maven-war-plugin/target/it/war-resources/src/main/webapp]
[DEBUG]  + index.jsp has been copied.
[DEBUG]  + WEB-INF/web.xml has been copied.
[DEBUG] Dump of the current build pathSet content -->
[DEBUG] index.jsp
[DEBUG] WEB-INF/web.xml
[DEBUG] -- end of dump --

As a workaround - using <targetPath></targetPath> (empty) or dropping it - works fine.

@lprimak

[lprimak]

Thanks Piotrek for the mention. I can reproduce this issue.

[mauromol]

I was also hit by this regression. When do you plan to release an updated fixed version?

[slawekjaranowski]

I was also hit by this regression. When do you plan to release an updated fixed version?

on my list ... I will look at weekend