Skip to content

Conversation

@slawekjaranowski
Copy link
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Copy link
Contributor

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TODO should also have an issue - to be visible and part of the release notes.

Also the PR should be titles as "Fix build for JDK 25" right? as the build is not fixed by using JDK 25?

@slawekjaranowski slawekjaranowski changed the title Fix build by JDK 25 Fix build for JDK 25 Oct 7, 2025
@slawekjaranowski
Copy link
Member Author

The TODO should also have an issue - to be visible and part of the release notes.

Only PRs are part of release notes.

@slawekjaranowski slawekjaranowski merged commit 10545c6 into apache:master Oct 7, 2025
20 checks passed
@slawekjaranowski slawekjaranowski deleted the jdk25 branch October 7, 2025 20:32
@github-actions github-actions bot added this to the 3.4.1 milestone Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants