chore: Migrate AbstractMojoTestCase based tests to use MojoTest #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
sparsick
force-pushed
the
abstractmojotestcase-migration
branch
3 times, most recently
from
b7a757a to
5e7b59d
Compare
sparsick
commented
Nov 5, 2025
src/test/java/org/apache/maven/plugins/war/WarExplodedMojoFilteringTest.java
Show resolved
Hide resolved
src/test/java/org/apache/maven/plugins/war/WarExplodedMojoFilteringTest.java
Outdated
Show resolved
Hide resolved
elharo
requested changes
Nov 25, 2025
… - WarExplodedMojoFilteringTest
…ExplodedMojoFilteringTest
Contributor
Author
|
Trying to reproduce the Windows error of the CI |
sparsick
force-pushed
the
abstractmojotestcase-migration
branch
from
782a2b3 to
2ff6a08
Compare
Contributor
Author
On Windows 11, it is not reproducible. |
Contributor
Author
Reproducible, if the you clone the repo with a windows git. Root cause: Git on Windows check out the expected file with windows encoding, but the generated one is unix encoding. It can be fixed with the git config: At the end, I fixed it with adding a |
sparsick
force-pushed
the
abstractmojotestcase-migration
branch
from
8004c09 to
2ca3df2
Compare
sparsick
force-pushed
the
abstractmojotestcase-migration
branch
from
2ca3df2 to
eac328b
Compare
| # limitations under the License. | ||
| # | ||
|
|
||
| * text=auto eol=lf No newline at end of file |
Member
There was a problem hiding this comment.
I'm not sure if we should switch all project file ... maybe only this which generate a problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.