Skip to content

Conversation

@Bukama
Copy link
Contributor

@Bukama Bukama commented Mar 24, 2025

Plugin has only one branch and no Maven 4 version, so only simple release-drafter

@Bukama Bukama requested a review from slawekjaranowski March 24, 2025 20:31
@Bukama Bukama self-assigned this Mar 24, 2025

_extends: maven-gh-actions-shared

tag-template: maven-war-plugin-$RESOLVED_VERSION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from parent 44 we will have tag as v<Version> do default one will be ok, we can drop this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I'll remove it, but we should upgrade to parent soon then to don't run into problems I think

Comment on lines 22 to 23
include-pre-releases: true
prerelease: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have only one production branch we don't have a beta and other pre - release version here

Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@Bukama
Copy link
Contributor Author

Bukama commented Mar 25, 2025

Updated, please have another look. Thank you.

@Bukama Bukama requested a review from slawekjaranowski March 25, 2025 05:04
@Bukama Bukama merged commit ae9b535 into apache:master Mar 26, 2025
48 checks passed
@Bukama Bukama deleted the ghactions branch March 26, 2025 16:03
@github-actions github-actions bot added this to the 3.4.1 milestone Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants