Cannot use interpolated variables in <repository> section

[lprimak]

Affected version

4.0.0-rc-4 and master

Bug description

If an interpolated variable is used in <repositories><repository><url> section of the POM,
Maven will erroneously throw the below error.
This is evident if the project uses use EclipseLink 4.0.7.

[ERROR] Failed to execute goal on project apps-root: Could not collect dependencies for project com.flowlogix:apps-root:pom:1.x-SNAPSHOT
[ERROR] java.lang.IllegalArgumentException: Invalid Version Range Request: org.eclipse.ee4j:project:pom:1.0.9 < [hope-repository (https://nexus.hope.nyc.ny.us/repository/maven-releases, default, releases), central-mirror (https://nexus.hope.nyc.ny.us/repository/maven-public-jitpack, default, releases), sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
[ERROR] 	Caused by: Invalid Version Range Request: org.eclipse.ee4j:project:pom:1.0.9 < [hope-repository (https://nexus.hope.nyc.ny.us/repository/maven-releases, default, releases), central-mirror (https://nexus.hope.nyc.ny.us/repository/maven-public-jitpack, default, releases), sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
[ERROR] : Failed to collect dependencies at org.eclipse.persistence:org.eclipse.persistence.jpa.modelgen.processor:jar:4.0.7

[gnodet]

The use of project properties in repository URLs is now forbidden. You can use user or system properties configured in .mvn/maven.config (in Maven 3 or 4) or /.mvn/maven.properties (in Maven 4).

[lprimak]

Thanks for the explanation.

You can use user or system properties

I am not sure how this can help solve the problem.
Take a look at https://central.sonatype.com/artifact/org.eclipse.persistence/org.eclipse.persistence.parent/4.0.7
This is already in maven central. When my project depends (directly or transitively) on this POM, the error occurs.

How can this be fixed so that all users of this POM don't have to declare sonatypeOssDistMgmtNexusUrl and sonatypeOssDistMgmtStagingUrl?
.mvn/settings.xml is not available in maven 3, so I can't put the <repository> section there.
Is there something I am missing? How can this be fixed so the project can both be build and used by maven 3 and 4?

[Bukama]

.mvn/settings.xml is not available in maven 3, so I can't put the <repository> section there.

You can but the settings.xml in any folder in your repository and link it via .mvn/maven.config putting a -s path/to/settings.xml in there

[lprimak]

link it via .mvn/maven.config putting a -s path/to/settings.xml in there

Unfortunately that precludes the use of ~/.m2/settings.xml as far as I know.
That settings file is used in CI for builds and releases.
Hence, this solution brings another issue.

[gnodet]

We may want to forbid the usage of such POMs containing uninterpolated properties when loading projects, while simply raising a warning when loading them from remote repositories. @cstamas would that make sense ?

[lprimak]

I think that would solve the problem. Please make the warning in a separate logger so it can be individually turned off.

[lprimak]

Also there is another issue. CycloneDX plugin fails on the EclipseLink POM as well. Not sure if that's at all related.

[INFO] [stdout]     [INFO] --- cyclonedx:2.9.1:makeAggregateBom (default) @ flowlogix-datamodel ---
[INFO] [stdout]     [INFO] CycloneDX: Resolving Dependencies
[INFO] [stdout]     [WARNING] Failed to build parent project for org.eclipse.persistence:org.eclipse.persistence.jpa.modelgen.processor:jar:4.0.7
[INFO] [stdout]     [WARNING] Failed to build parent project for org.eclipse.persistence:org.eclipse.persistence.jpa:jar:4.0.7
[INFO] [stdout]     [WARNING] Failed to build parent project for org.eclipse.persistence:org.eclipse.persistence.core:jar:4.0.7
[INFO] [stdout]     [WARNING] Failed to build parent project for org.eclipse.persistence:org.eclipse.persistence.jpa.jpql:jar:4.0.7

(hangs)

[cstamas]

Please see #11021 and retest if possible. PR is #11037

[lprimak]

PR checked good by @cstamas - thank you!

[lprimak]

fixed by #11037