[MNG-4645] Move Central repo definition out of Maven's jars so it can be more easily changed

[jira-importer]

Paul Gier opened MNG-4645 and commented

The Maven Central Repository definition is currently a hidden default repository available to Maven. The configuration of the Central Repo can be changed only if you know the (somewhat obscure) repository id "central": who knows that it is defined in Maven Super POM, defined in Maven Model Builder?

It would be better if the configuration of the central repository was moved from the Maven internals to the default settings.xml.

This way the repository would still be available to a default Maven install, but would also be clear to users how the central repo is configured in case it needs to be changed for mirror settings or some other reason. It would also make the repository ordering in the settings more clear.

---

Affects: 3.3.3

Issue Links:

• MNG-6112 Align artifacts and plugins policies using the default value
  ("contains")

• MNG-4347 import-scoped dependencies of direct dependencies are not resolved using profile modifications from settings.xml

• MNG-8730 Fix versions of new items in settings.xml

• MNG-5689 Checksum policy for mirrors

• MNG-5672 Switch access to Maven Central to HTTPS

• MNG-7059 Add profile-free repository support in Maven Settings model
  ("depends upon")

Remote Links:

• Page
  
• GitHub Pull Request #266
  
• GitHub Pull Request #1139
  
• GitHub Pull Request #419
  

Backported to: 4.0.0-alpha-7

3 votes, 12 watchers

[jira-importer]

Jason van Zyl commented

Please refer to https://cwiki.apache.org/confluence/display/MAVEN/The+Great+JIRA+Cleanup+of+2014

[jira-importer]

Jason van Zyl commented

Please refer to https://cwiki.apache.org/confluence/display/MAVEN/The+Great+JIRA+Cleanup+of+2014 if you're wondering why this issue was closed out.

[jira-importer]

Michael Osipov commented

I wouldn't say that this issue is resolved. RepositorySystem still has DEFAULT_REMOTE_REPO_URL and MavenRepositorySystem/DefaultMavenExecutionRequestPopulator#injectDefaultRepositories/injectDefaultPluginRepositories still use it. WDYT Christian?

[jira-importer]

Michael Osipov commented

Additionally, why is the updatePolicy not set to never on <repository/>?

[jira-importer]

Christian Schulte commented

The intention to move the repositories out of the super POM is to have that somewhere users can modify it without requiring to update resources in some Maven JAR and to allow for easier ordering of repositories in the settings. I agree that there is no reason to keep Maven to falling back to some hardcoded central repository if such a repository is not setup anywhere else. See my last commit removing that from the core. Thanks.

[jira-importer]

Christian Schulte commented

Good catch. I just copied that from the super POM to the settings.

[jira-importer]

Christian Schulte commented

|Initial version|r162925|History|
|Renamed|r163086|History|
|Deleted|r727291|History|
|Re-added|r727292|History|
|Moved|r767707|History|
|Renamed|r786855|History|

Where it still resides today. It really never had update policy never. I did not look if the default of that update policy ever changed. It defaults to daily, AFAIK.

[jira-importer]

Michael Osipov commented

Looks better now. Finally, one can swap central for a Nexus instance without setting a mirrorOf.

I would also rename Central Repository to Maven Central Repository and document that there is an official mirror in the UK.

[jira-importer]

Michael Osipov commented

The Core IT Suite includes a file settings-remote.xml which should reworked for this change.

[jira-importer]

Christian Schulte commented

What should be reworked there? If Maven is told to use a different settings.xml, the new default profile is never used / there is no repository setup anywhere. So the settings-remote.xml is the only source declaring repositories.

[jira-importer]

Christian Schulte commented

This has been reverted for 3.4 and postponed for model version 5.0.0.

[jira-importer]

Christian Schulte commented

We tried removing the repositories from the super POM for Maven 3.4 and needed to revert the changes. Having the repositories in the super POM makes no sense. It only works for projects not declaring another parent. Because of this, the repositories are hard-coded in 'maven-core' as well. When trying to move the repositories to the default settings.xml, various issues were encountered.

• The only way to declare the repositories in the settings is by adding a profile to the default settings. This profile needs to declare an id not conflicting with any other profile. We used a UUID for this id.

• Due to the way effective settings are build, profiles from the global settings get ordered incorrectly. See MNG-6114 and this thread on dev@.

We decided to not change anything about the repositories until the settings model gets enhanced to support repository declarations directly without the need to use profiles.

[jira-importer]

Robert Scholte commented

With settings-1.0.0 you can only define repositories via a profile. I don't like the idea to claim a profile id just to be able to configure central. Would it make sense to extend settings with 1 repository and 1 pluginRepository at top level?

[jira-importer]

Michael Osipov commented

Robert Scholte, why do we need the separation between repo and plugin repo at all these days? What makes plugins so special from a repo point of view?

[jira-importer]

Michael Osipov commented

Robert Scholte, we likely need to consider to have full support for repos in settings model instead of having just in profiles. We always said that we don't want to have repos in POMs at best.