[MNG-7055] Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into maven-metadata.xml

[jira-importer]

Elliotte Rusty Harold opened MNG-7055 and commented

explanation: metadata/plugins content in maven-metadata.xml descriptor from plugin's groupId is not updated (ie. plugin/name+prefix+artifactId) on first plugin release deployment, then plugin's prefix is not published

see for example existing plugin data in https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-metadata.xml

Copying Michael Osipov's comment from mailing list on HEAD with Maven core ITs:

https://markmail.org/message/ggcioupa6yaet4xe#query:+page:1+mid:noyp5d3iyclrfgyp+state:results

[ERROR] Tests run: 834, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 287.261 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
[ERROR] testitMNG3372(org.apache.maven.it.MavenITmng3372DirectInvocationOfPluginsTest)
Time elapsed: 1.5 s  <<< ERROR!
org.apache.maven.it.VerificationException:
Exit code was non-zero: 1; command line and log =
/var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/apache-maven/bin/mvn
--global-settings
/var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/test-classes/settings.xml
-s
/var/osipovmi/Projekte/maven-integration-testing/core-it-suite/target/test-classes/mng-3372/direct-using-prefix/settings.xml
-e --batch-mode
-Dmaven.repo.local=/net/home/osipovmi/var/Projekte/maven-integration-testing/repo
mng3372:test
[INFO] Error stacktraces are turned on.
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for
org.apache.maven.its.mng3372:project:jar:1.0-SNAPSHOT
[WARNING] Version not locked for default bindings plugins [maven-clean-plugin,
maven-resources-plugin, maven-jar-plugin, maven-compiler-plugin,
maven-surefire-plugin, maven-install-plugin, maven-deploy-plugin,
maven-site-plugin], you should define versions in pluginManagement section of
your pom.xml or parent @ line 6, column 14
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
[INFO] Downloading from central: file:target/null/org/apache/maven/its/mng3372/maven-metadata.xml
[INFO] Downloading from central: file:target/null/org/apache/maven/plugins/maven-metadata.xml
[INFO] Downloading from central: file:target/null/org/codehaus/mojo/maven-metadata.xml
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.056 s
[INFO] Finished at: 2020-06-04T22:03:01+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] No plugin found for prefix 'mng3372' in the current project and in the
plugin groups [org.apache.maven.its.mng3372, org.apache.maven.plugins,
org.codehaus.mojo] available from the repositories [local
(/net/home/osipovmi/var/Projekte/maven-integration-testing/repo), central
(file:target/null)] -> [Help 1]
org.apache.maven.plugin.prefix.NoPluginFoundForPrefixException: No plugin found
for prefix 'mng3372' in the current project and in the plugin groups
[org.apache.maven.its.mng3372, org.apache.maven.plugins, org.codehaus.mojo]
available from the repositories [local (/net/home/osipovmi/var/Projekte/maven-integration-testing/repo), central (file:target/null)]
    at org.apache.maven.plugin.prefix.internal.DefaultPluginPrefixResolver.resolve(DefaultPluginPrefixResolver.java:98)
    at org.apache.maven.lifecycle.internal.MojoDescriptorCreator.findPluginForPrefix(MojoDescriptorCreator.java:269)
    at org.apache.maven.lifecycle.internal.MojoDescriptorCreator.getMojoDescript

---

Issue Links:

• MPOM-332 Upgrade maven-deploy-plugin to 3.1.1
  ("blocks")

• MSHARED-920 NPE in DefaultArtifactInstaller.install - missing injection of RepositoryManager

• MNG-7870 Undeprecate wrongly deprecated repository metadata

• MNG-6556 Packaging 'maven-plugin' binding plugin upgrades

• MPLUGIN-384 Nexus Staging Plugin - incompatibility

• MNG-7375 Potential NPE in o.a.m.artifact.repository.metadata.Metadata.merge(...) with invalid/incomplete plugin metadata

• MDEPLOY-291 Update POM parent and Maven + warn if older Maven is used to build a Maven plugin (as impacted by MNG-7055)

• MPOM-368 Bump maven-install-plugin from 2.5.2 to 3.0.1

Remote Links:

• GitHub Pull Request #555
  
• GitHub Pull Request #691
  
• Github Pull Request #691 (backport to 3.9.x)
  

Backported to: 4.0.0-alpha-2, 3.9.0

0 votes, 11 watchers

[jira-importer]

Michael Osipov commented

I did more investigation and the cause of this is:

commit 55f1f640dff5e2dbdd44d53949bb0735a7e78d26
Author: Robert Scholte <rfscholte@apache.org>
Date:   2015-10-11T20:39:20+02:00

    Merge with 3.0-branch

    git-svn-id: https://svn.apache.org/repos/asf/maven/plugins/trunk@1708008 13f79535-47bb-0310-9956-ffa450edef68

With this change Maven Artifact Manager has been replaced with Manager Artifact Transfer. It does not touch group repository metadata at all, it simply ignores plugins.

[jira-importer]

Michael Osipov commented

Robert Scholte, I know it has been many years, but do you remember anything special with that change?

[jira-importer]

Robert Scholte commented

Looking at it, this looks like this is the start of dropping the Maven2 mechanism to install artifacts and to start using Aether/Maven Artifact Resolver. Looks unrelated to the error.

[jira-importer]

Michael Osipov commented

It seems, but it is not. Artifact Manager did take care of plugin metadata in the repo while Artifact Transfer does not anymore. Can we completely get rid of Artifact Transfer?

[jira-importer]

Robert Scholte commented

Artifact Transfer is just a bridge, to make it possible to work with Sonetype Aether and Eclipse Aether. The logic for plugin metadata doesn't belong there. I don't know where it should be now.

[jira-importer]

Michael Osipov commented

I agree with that because this is packaging specific. The problem is the it currently not possible to install or deploy that piece of information with MINSTALL/MDEPLOY 3.0.0-x. Maven needs this metadata to work properly, so we have to solve this problem somehow.

[jira-importer]

Robert Scholte commented

IMO this belongs in Maven itself, not in a library or plugin. I'll need ito investigate if there is a clean way for plugin artifacts to hook into MAven Artifact Resolver

[jira-importer]

Michael Osipov commented

Thanks, this is really something to be very nice in 4.0.0. Let me know if I can help.

[jira-importer]

Michael Osipov commented

So this should be moved to MNG and I can perform a release of this component?

[jira-importer]

Robert Scholte commented

issue is unrelated to maven-artifact-transfer, so go ahead.

[jira-importer]

Maarten Mulders commented

Martin Kanters and I will start working on this. We will move the existing "install / deploy" logic into Core, implementing it on top of Maven Resolver API. The M-I-P and M-D-P will leverage that, but they will still need a fallback (implemented with Eclipse Aether) so they are compatible with Maven 3.1 and above. We expect to drop Maven 3.0 compatibility.

[jira-importer]

Tamas Cservenak commented

Failing ITs when update m-i-p and m-d-p to 3.x are:

[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   MavenITmng3441MetadataUpdatedFromDeploymentRepositoryTest>AbstractMavenIntegrationTestCase.runTest:265->testitMNG3441:72 expected:<[test-artifact]> but was:<[blah]>
[ERROR] Errors: 
[ERROR]   MavenITmng3372DirectInvocationOfPluginsTest>AbstractMavenIntegrationTestCase.runTest:265->testitMNG3372:65 » Verification
[INFO] 
[ERROR] Tests run: 879, Failures: 1, Errors: 1, Skipped: 0
 

[jira-importer]

Michael Osipov commented

Tamas Cservenak, can you tell whether this can/should be backported to 3.9.0?

[jira-importer]

Tamas Cservenak commented

I would try to backport it, it's a real shame that two of most important plugins (install and deploy) were NEVER released for maven 3 as 3.x.x

[jira-importer]

Tamas Cservenak commented

Backported as #691, locally tested and all ok. Please bless it (pretty much same change as already scrutinized original PR).