[MNG-7285] [Regression] MavenProject.getArtifacts() not returning correct value across multiple threads

[jira-importer]

Mickael Istria opened MNG-7285 and commented

Patch for MNG-6843 seems to cause that when trying to use MavenProject.getArtifacts() across different threads, some of them get an incorrect result.

This cause an issue in m2e where we schedule a lot of work and don't have much control over which thread will do the work (there is a thread pool); we've faced several regressions because of this issue when trying to adopt 3.8.3 from 3.8.1. More details at https://github.com/eclipse-m2e/m2e-core/pull/346 , https://github.com/eclipse-m2e/m2e-core/pull/347 and eclipse-m2e/m2e-core#350 .

I'll try to capture it in a test case for maven repo in the next days.

---

Affects: 3.0-alpha-1, 3.8.2, 3.8.3

Issue Links:

• MNG-7312 Revert ThreadLocal approach from MNG-6843 and MNG-7251
  ("is fixed by")

• MNG-7156 Parallel build can cause issues between clean and forked goals

• MNG-6843 Parallel build fails due to missing JAR artifacts in compilePath
  ("is broken by")

Remote Links:

• GitHub Pull Request #570
  
• GitHub Pull Request #578
  

Backported to: 4.0.0-alpha-2, 3.8.4

0 votes, 8 watchers

[jira-importer]

Michael Osipov commented

Can this be reproduced within m2e only?

[jira-importer]

Mickael Istria commented

I also believe that some mojos, or even Maven core, running with a -T<threads> option can reach this issue.

[jira-importer]

Michael Osipov commented

If you can reproduce the issue, you can try to revert those two commits by Falko Modler and see whether your issue is fixed. However, I guess a revert will break other things :-(

[jira-importer]

Michael Osipov commented

Here they are: https://github.com/apache/maven/commits?author=famod

[jira-importer]

Michael Osipov commented

Falko Modler, please stay tuned.

[jira-importer]

Mickael Istria commented

PR at #570 shows the regression. This same test is working with maven 3.8.1 and starts failing since 3.8.3.

I think any mojo that uses project.getArtifacts() can get faulty result if using parallel build.

[jira-importer]

Michael Osipov commented

Mickael Istria, I guess this issue applies to master as well?

[jira-importer]

Mickael Istria commented

I guess this issue applies to master as well?

I guess so; but we didn't try for m2e as there are other issues with Maven 4 that prevents us to go far enough to notice this bug.