[MNG-7556] Clean up notion between user properties and system properties

[jira-importer]

Michael Osipov opened MNG-7556 and commented

For a very long time we have documented that the user can set system properties via mvn -Dfoo=bar, but actually those are user properties which are promoted to system properties and it some cases system properties cannot be modified after the JVM has been started. To properly set system properties there are basically two ways:

• use MAVEN_OPTS environment variable
• use .mvn/jvm.config file

A third option in the future we could introduce, like other Java tools, a -J-Dfoo=bar option with the restriction of the the paragraph above.

---

Issue Links:

• MNG-7887 cannot inject ci-friendly revision/sha1/changelist properties via MAVEN_OPTS
  ("causes")

• MNG-7782 System properties are no longer overridden with user properties with the same name

• MSHARED-1132 Improved handling of system and user properties

Remote Links:

• GitHub Pull Request #810
  

Backported to: 4.0.0-alpha-3, 3.9.0

[jira-importer]

Michael Osipov commented

sjaranowski, this has impact on the changes in Maven Verifier 2.0.0.

[jira-importer]

Slawomir Jaranowski commented

Verifier use system properties in different way for embedded mode and for forked mode - MSHARED-1132

[jira-importer]

Michael Osipov commented

Agree, but the current state is incorrect. Not only your cleanup is necessary, but also the introduction of #setUserPropert...(...). This will make it clean and properly replicate real life.

[jira-importer]

Michael Osipov commented

Fixed with 9c6013891504d5eb1d8bad18772a7fe114131d61 and with 0f4387543debd77ab649f97014b72feb4046b3c6 for maven-3.9.x branch.