Disallow arbitrary namespaces in Maven and Metadata readers by arturobernalg · Pull Request #11185 · apache/maven

arturobernalg · 2025-09-28T17:59:07Z

Accept POM 4.1.0 and METADATA 1.1.0 plus no-namespace, reject others Add JUnit tests for valid and invalid namespaces

Following this checklist to help us incorporate your
contribution quickly and easily:

[ X] Your pull request should address just one issue, without pulling in other changes.
[ X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ X] Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
[X ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
[X ] Run mvn verify to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.

elharo

avoid abbreviations

elharo · 2025-09-28T18:31:06Z

+    @Test
+    void acceptsPom41() throws Exception {
+        MavenStaxReader reader = new MavenStaxReader();
+        Model m = reader.read(new StringReader(POM_41), /*strict*/ true, NO_INPUT_SOURCE);


m --> model

elharo · 2025-09-28T18:31:16Z

+    @Test
+    void acceptsPomWithoutNamespace() throws Exception {
+        MavenStaxReader reader = new MavenStaxReader();
+        Model m = reader.read(new StringReader(POM_NO_NS), true, NO_INPUT_SOURCE);


m --> model

elharo · 2025-09-28T18:31:32Z

+        XMLStreamException ex = assertThrows(
+                XMLStreamException.class, () -> reader.read(new StringReader(POM_BAD_NS), true, NO_INPUT_SOURCE));
+        // sanity check: message mentions unrecognized namespace
+        assertTrue(ex.getMessage().toLowerCase().contains("unrecognized pom namespace"));


Locale.ROOT

elharo · 2025-09-28T18:31:58Z

+    @Test
+    void acceptsMetadata110() throws Exception {
+        MetadataStaxReader reader = new MetadataStaxReader();
+        Metadata md = reader.read(new StringReader(META_110), /*strict*/ true);


md --> metadata

elharo · 2025-09-28T18:32:21Z

+    }
+
+    // Enforce root namespace per model (strict mode).
+    String rootNs = parser.getNamespaceURI();


rootNamespace

elharo · 2025-09-28T18:32:26Z

+
+    // Enforce root namespace per model (strict mode).
+    String rootNs = parser.getNamespaceURI();
+    boolean hasNs = rootNs != null && !rootNs.isEmpty();


hasNamespace

gnodet · 2025-09-28T20:13:00Z

-     * any.
-     * @return ${root.name}
-     */
+/**


Fix the formatting of this file, this completely breaks the format of the generated java file.

gnodet · 2025-09-28T20:17:36Z

+    if (strict && hasNs) {
+    if ("project".equals("${rootTag}")) {
+    // Accept any official POM namespace version (e.g., 4.0.0, 4.1.0)
+    if (!rootNs.startsWith("http://maven.apache.org/POM/")) {


These hardcoded values are wrong. We generate much more readers than just those two: settings, lifecycles, extensions, plugin, toolchains...
In addition, accepting metadata namespace when reading a POM is just plain wrong.
The way to go would be to define a variable for the template in the POM that generates the writer and only accept that one.
Another thing to keep in mind is that the plugin configuration in the POM can actually contain external namespaces and this is valid.

An example of such a variable is ${packageToolV4}.

gnodet

Hardcoding the namespace is wrong.

Accept POM 4.1.0 and METADATA 1.1.0 plus no-namespace, reject others Add JUnit tests for valid and invalid namespaces

arturobernalg · 2025-09-29T11:05:26Z

Hardcoding the namespace is wrong.

@gnodet please do another pass

gnodet · 2025-09-29T15:50:10Z

+        final boolean hasNs = rootNs != null && !rootNs.isEmpty();
+
+        if ("project".equals("${rootTag}")) {
+            if (hasNs && !rootNs.startsWith("http://maven.apache.org/POM/")) {


This is wrong. We have generators to generate specific readers, not a generic one which covers all use cases. So it's wrong to put hardcoded values for one or two models in the output of all readers.
The way to go is to retrieve the namespace using modello. The helper needs to be enhanced:
https://github.com/codehaus-plexus/modello/blob/ca30aba14346bf0e183efd2c442f061024c40111/modello-plugins/modello-plugin-velocity/src/main/java/org/codehaus/modello/plugin/velocity/Helper.java
It needs a new method xmlModelMetadata which would return the XmlModelMetadata from which we can get the target namespace.
Once modello is fixed, we can update the velocity templates to leverage that using Helper.xmlModelMetadata(model).namespace.

See codehaus-plexus/modello#522

gnodet

Unfortunately, I think we need to enhance modello to provide access to the target namespace using $Helper.xmlModelMetadata(model).namespace.

arturobernalg mentioned this pull request Sep 28, 2025

Maven allows random namespaces on project #10985

Open

elharo reviewed Sep 28, 2025

View reviewed changes

elharo changed the title ~~Fix namespace handling in Maven and Metadata readers~~ Disallow arbitrary namespaces in Maven and Metadata readers Sep 28, 2025

arturobernalg force-pushed the 10985 branch from 25d4fb8 to c5bbb38 Compare September 28, 2025 19:19

arturobernalg requested a review from elharo September 28, 2025 19:19

gnodet reviewed Sep 28, 2025

View reviewed changes

gnodet approved these changes Sep 28, 2025

View reviewed changes

Fix namespace handling in Maven and Metadata readers

da106d1

Accept POM 4.1.0 and METADATA 1.1.0 plus no-namespace, reject others Add JUnit tests for valid and invalid namespaces

arturobernalg force-pushed the 10985 branch from c8fe7a7 to da106d1 Compare September 29, 2025 11:05

arturobernalg requested a review from gnodet September 29, 2025 11:05

gnodet reviewed Sep 29, 2025

View reviewed changes

gnodet requested changes Sep 29, 2025

View reviewed changes

Conversation

arturobernalg commented Sep 28, 2025

Uh oh!

elharo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gnodet left a comment

Choose a reason for hiding this comment

Uh oh!

arturobernalg commented Sep 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gnodet left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants