Skip to content

[prone] Add UnusedVariable#11284

Closed
Pankraz76 wants to merge 1 commit intoapache:masterfrom
Pankraz76:prone
Closed

[prone] Add UnusedVariable#11284
Pankraz76 wants to merge 1 commit intoapache:masterfrom
Pankraz76:prone

Conversation

@Pankraz76
Copy link
Copy Markdown
Contributor

@Pankraz76 Pankraz76 commented Oct 16, 2025 •
edited
Loading

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

enabler for:

related to:

@Pankraz76 Pankraz76 mentioned this pull request Oct 16, 2025
Closed
gnodet
gnodet requested changes Oct 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain how you found those issues, as some of them are just plain wrong. It also contains lots of unrelated changes.

@Pankraz76 Pankraz76 changed the title [prone] Add DirectReturn [prone] Add UnusedVariable Oct 16, 2025
Pankraz76
Pankraz76 commented Oct 16, 2025
View reviewed changes
Comment thread pom.xml Outdated
@Pankraz76
Copy link
Copy Markdown
Contributor Author

Pankraz76 commented Oct 16, 2025

Can you explain how you found those issues, as some of them are just plain wrong. It also contains lots of unrelated changes.

updated to something simple like unused variable. Direct return is something to consider later on as in this case its quite "complex".

@Pankraz76 Pankraz76 requested a review from gnodet October 16, 2025 14:28
@Pankraz76 Pankraz76 marked this pull request as ready for review October 16, 2025 14:28
Pankraz76
Pankraz76 commented Oct 16, 2025
View reviewed changes
Comment thread api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java
Comment thread impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelObjectPool.java
Comment thread impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelObjectPool.java
Comment thread impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelObjectPool.java
Pankraz76
Pankraz76 commented Oct 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@Pankraz76 Pankraz76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 ct.

Comment thread impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSettingsBuilder.java
Comment thread impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSettingsBuilder.java Outdated
gnodet
gnodet requested changes Oct 16, 2025
View reviewed changes
Comment thread api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java
Comment thread impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelObjectPool.java
Comment thread impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelObjectPool.java Outdated
Comment thread impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelObjectPool.java Outdated
Comment thread impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSettingsBuilder.java
src = Interpolator.chain(userProperties::get, systemProperties::get);
}
return new DefSettingsTransformer(value -> value != null ? interpolator.interpolate(value, src) : null)
private Settings interpolate(Settings settings, SettingsBuilderRequest request) {
Copy link
Copy Markdown
Contributor

@gnodet gnodet Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, those are not unused variables. These are intermediary results.
Your refactoring hinders readability.

Copy link
Copy Markdown
Contributor Author

@Pankraz76 Pankraz76 Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ppl wondering just like the SCA why its unused or ignored. Having it named accordingly or removed seems to be the best practise in order to turn the questions into answers, as history is mystery.

Copy link
Copy Markdown
Contributor

@Bukama Bukama Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ppl wondering just like the SCA why its unused or ignored. Having it named accordingly or removed seems to be the best practise in order to turn the questions into answers, as history is mystery.

best practice is to understand what you are refactoring instead of blindly trusting tools/AI

Copy link
Copy Markdown
Contributor Author

@Pankraz76 Pankraz76 Oct 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could argue that "understanding" is a complex goal for this codebase. The presence of incorrect, ignored, and unused segments suggests that the original intent has become obscured over time. It's likely the logic was once valid, but that context has been lost.

The system continues to operate, but its current behavior appears disconnected from its actual purpose, seemingly functioning through emergent coincidence rather than by explicit design (no unused stuff dangling around).

In these situations, static code analysis becomes a valuable tool for reconstructing the rationale behind the code. As team members move on, institutional knowledge fades, and manual auditing does not scale effectively.

From my perspective, comprehending the full scope is challenging. For instance, the purpose of an unused field isn't clear, requiring me to hypothesize about its original function.

Ideally, code should narrate its purpose like a coherent story, with each line building upon the last. Gaps in this narrative—such as unused components or logical inconsistencies—highlight areas where the underlying purpose has been lost. While there may be valid, albeit hidden, reasons for these anomalies, the process of understanding involves methodically converting these open questions into resolved answers to piece together the complete picture.

Comment thread pom.xml Outdated
Comment thread impl/maven-xml/src/main/java/org/apache/maven/internal/xml/XmlNodeImpl.java
Comment thread .mvn/jvm.config Outdated
@Pankraz76 Pankraz76 force-pushed the prone branch 2 times, most recently from dfa71eb to 9b9f1c6 Compare October 16, 2025 16:20
Pankraz76
Pankraz76 commented Oct 16, 2025
View reviewed changes
Comment thread api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java
Comment thread compat/maven-model/src/test/java/org/apache/maven/model/v4/ModelXmlTest.java Outdated
@Pankraz76 Pankraz76 requested a review from gnodet October 16, 2025 16:40
@Pankraz76 Pankraz76 force-pushed the prone branch 2 times, most recently from 9c45a03 to 80c922b Compare October 16, 2025 17:40
Pankraz76
Pankraz76 commented Oct 16, 2025
View reviewed changes
Comment thread impl/maven-xml/src/main/java/org/apache/maven/internal/xml/XmlNodeImpl.java
Comment thread api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java
Comment thread api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java Outdated
Pankraz76
Pankraz76 commented Oct 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@Pankraz76 Pankraz76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public by default.

Comment thread api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java
Comment thread api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java
Comment thread api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java
@Pankraz76 Pankraz76 marked this pull request as draft October 16, 2025 17:45
gnodet
gnodet requested changes Oct 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has, once again, derailed.
It contains changes which have nothing in common.
Please split PR:

  • one for the """ string blocks, but maybe look at the whole codebase where it makes sense
  • one for XmlNode.toString refactoring
  • one for removing unused variables (but without any other refactoring)

Comment thread api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java Outdated
Comment thread api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java Outdated
Comment thread api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java Outdated
Comment thread api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java Outdated
Comment thread api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java Outdated
Comment thread api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlService.java Outdated
Pankraz76
Pankraz76 commented Oct 17, 2025
View reviewed changes
Comment thread api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java Outdated
Comment thread api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java Outdated
Comment thread api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java
Comment thread api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java Outdated
@Pankraz76 Pankraz76 requested review from Bukama and gnodet October 17, 2025 08:01
@Pankraz76 Pankraz76 marked this pull request as ready for review October 17, 2025 08:18
gnodet
gnodet reviewed Oct 17, 2025
View reviewed changes
Comment thread impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelObjectPool.java Outdated
@Pankraz76 Pankraz76 requested a review from gnodet October 17, 2025 09:29
@Pankraz76
Copy link
Copy Markdown
Contributor Author

Pankraz76 commented Oct 28, 2025

reopen once considering.

@Pankraz76 Pankraz76 closed this Oct 28, 2025
@gnodet
Copy link
Copy Markdown
Contributor

gnodet commented Oct 28, 2025

The problem is that the build was failing IIRC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bukama Bukama Awaiting requested review from Bukama

@gnodet gnodet Awaiting requested review from gnodet

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pankraz76 @gnodet @Bukama