Feat: migrate core to JSR330#11916
Merged
cstamas merged 15 commits intoapache:maven-3.10.xfrom Apr 10, 2026
Merged
Conversation
Only at places where logger was well encapsulated.
To stop confusion about field vs setter.
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Apr 9, 2026
| Map<String, LifecycleMapping> filtered = new HashMap<>(); | ||
| // filter by visibility (plexus vs sisu diff; "realms" are plexus thing) | ||
| // in some tests container is not injected | ||
| if (this.plexusContainer != null) { |
Member
There was a problem hiding this comment.
Is it possible to have null value for @Inject
If it is problem in tests maybe we should fix test?
Member
Author
There was a problem hiding this comment.
Yes, UT only. At runtime guice will fail if nothing to inject (and injection point is not nullable)
Member
There was a problem hiding this comment.
ok, we can try fix in next round 😄
slawekjaranowski
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
static!)