Skip to content

[MNG-6847] Use diamond operator#1264

Merged
gnodet merged 1 commit intoapache:masterfrom
timtebeek:refactor/use-diamond-operator
Oct 19, 2023
Merged

[MNG-6847] Use diamond operator#1264
gnodet merged 1 commit intoapache:masterfrom
timtebeek:refactor/use-diamond-operator

Conversation

@timtebeek
Copy link
Copy Markdown
Contributor

Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/SEvWu02zw?organizationId=QXBhY2hlIE1hdmVu

Co-authored-by: Moderne <team@moderne.io>
Copy link
Copy Markdown
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elharo
Copy link
Copy Markdown
Contributor

elharo commented Sep 26, 2023

Tests might be broken at head. I don't think the failures are caused by this PR but we'll need to resolve that before merging this:

Error: Tests run: 3, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.327 s <<< FAILURE! - in org.apache.maven.it.MavenITmng7038RootdirTest
Error: org.apache.maven.it.MavenITmng7038RootdirTest.testRootdirWithTopdirAndRoot Time elapsed: 0.097 s <<< ERROR!
org.apache.maven.shared.verifier.VerificationException:
Exit code was non-zero: 1; command line and log =
/home/runner/work/maven/maven/maven-integration-testing/core-it-suite/target/apache-maven/bin/mvn -e --batch-mode -Dmaven.repo.local=/home/runner/.m2/repository --global-settings /home/runner/work/maven/maven/maven-integration-testing/core-it-suite/target/test-classes/settings.xml validate
[INFO] Error stacktraces are turned on.
[INFO] Making this build non-interactive, because the environment variable CI equals "true". Disable this detection by removing that variable or adding --force-interactive.
[INFO] Scanning for projects...
Error: Some problems were encountered while processing the POMs
Error: The build could not read 1 project -> [Help 1]

@gnodet gnodet merged commit 889ceb4 into apache:master Oct 19, 2023
@gnodet gnodet added this to the 4.0.0-alpha-8 milestone Oct 19, 2023
@timtebeek timtebeek deleted the refactor/use-diamond-operator branch October 19, 2023 07:44
@jira-importer
Copy link
Copy Markdown

Resolve #8447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants