Skip to content

[MNG-7893] Fix exception loading superpom with invalid modelVersion#1290

Merged
gnodet merged 1 commit intoapache:masterfrom
gnodet:fix-superpom
Oct 18, 2023
Merged

[MNG-7893] Fix exception loading superpom with invalid modelVersion#1290
gnodet merged 1 commit intoapache:masterfrom
gnodet:fix-superpom

Conversation

@gnodet
Copy link
Copy Markdown
Contributor

@gnodet gnodet commented Oct 18, 2023

Even though this should not be supported, Maven 3.x is always using the 4.0.0 superpom. So if the version is not a supported model version, simply use 4.0.0. Any invalid value will be later verified by the model validator and eventually throw a meaninfual exception.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Even though this should not be supported, Maven 3.x is always using the 4.0.0 superpom.  So if the version is not a supported model version, simply use 4.0.0.  Any invalid value will be later verified by the model validator and eventually throw a meaninfual exception.
@gnodet gnodet merged commit 251a316 into apache:master Oct 18, 2023
@gnodet gnodet deleted the fix-superpom branch November 1, 2023 21:47
@jira-importer
Copy link
Copy Markdown

Resolve #9028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants