[MNG-8075] Deprecate project.baseUri in favor of project.basedir.uri#2184
Draft
gnodet wants to merge 1 commit intoapache:masterfrom
Draft
[MNG-8075] Deprecate project.baseUri in favor of project.basedir.uri#2184gnodet wants to merge 1 commit intoapache:masterfrom
gnodet wants to merge 1 commit intoapache:masterfrom
Conversation
cstamas
approved these changes
May 23, 2025
|
Resolve #9801 |
gnodet
force-pushed
the
MNG-8075-deprecate-baseUri
branch
from
a470512 to
4b96f1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA issue: MNG-8075
The original issue was adding support for
${project.baseUri}, however, it has been inadvertently dropped when refactoring the Maven 4 model builder. Overall, instead of providing a new property, I think using the newly supported syntax of${project.basedir.uri}is a better idea.This PR isn't really complete as it only deprecates the expression in repository URIs for now.