Skip to content

No catch block needed when rethrowing same exception #2210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elharo merged 1 commit into from
Apr 3, 2025
Merged

No catch block needed when rethrowing same exception #2210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions impl/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginDescriptorCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,21 +67,17 @@ public PluginDescriptor get(Key cacheKey) {
public PluginDescriptor get(Key key, PluginDescriptorSupplier supplier)
throws PluginDescriptorParsingException, PluginResolutionException, InvalidPluginDescriptorException {

try {
PluginDescriptor desc = descriptors.get(key);
if (desc == null) {
synchronized (key) {
desc = descriptors.get(key);
if (desc == null) {
desc = supplier.load();
descriptors.putIfAbsent(key, clone(desc));
}
PluginDescriptor desc = descriptors.get(key);
if (desc == null) {
synchronized (key) {
desc = descriptors.get(key);
if (desc == null) {
desc = supplier.load();
descriptors.putIfAbsent(key, clone(desc));
}
}
return clone(desc);
} catch (PluginDescriptorParsingException | PluginResolutionException | InvalidPluginDescriptorException e) {
throw e;
}
return clone(desc);
}

public void put(Key cacheKey, PluginDescriptor pluginDescriptor) {
Expand Down