[MNG-6819] Fix NullPointerException in StringVisitorModelInterpolator$ModelVisitor by da-liii · Pull Request #301 · apache/maven

da-liii · 2019-12-13T12:09:15Z

Desc

Here is a clue to reproduce the NPE.

            <plugin>
                <artifactId>maven-antrun-plugin</artifactId>
                <executions>
                    <execution>
                        <phase>package</phase>
                        <configuration>
                            <tasks>
                                <unzip
                                    src="${project.build.directory}/${project.build.finalName}.${project.packaging}"
                                    dest="${project.build.directory}/xxx" />
                            </tasks>
                        </configuration>
                        <goals>
                            <goal>run</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>

project.build.finalName is the previous value, and the interpolated value is null.

Fix NullPointerException.

null is not allowed as a Hashtable value.

$ mvn clean compile -e  # on a private project
[ERROR] NullPointerException
java.lang.NullPointerException
    at java.util.Hashtable$Entry.setValue (Hashtable.java:1286)
    at org.apache.maven.model.interpolation.StringVisitorModelInterpolator$ModelVisitor.visit (StringVisitorModelInterpolator.java:1429)
    at org.apache.maven.model.interpolation.StringVisitorModelInterpolator$ModelVisitor.visit (StringVisitorModelInterpolator.java:1027)
    at org.apache.maven.model.interpolation.StringVisitorModelInterpolator$ModelVisitor.visit (StringVisitorModelInterpolator.java:170)
    at org.apache.maven.model.interpolation.StringVisitorModelInterpolator.interpolateModel (StringVisitorModelInterpolator.java:107)
    at org.apache.maven.model.building.DefaultModelBuilder.interpolateModel (DefaultModelBuilder.java:789)
    at org.apache.maven.model.building.DefaultModelBuilder.build (DefaultModelBuilder.java:393)
    at org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.loadPom (DefaultArtifactDescriptorReader.java:292)
    at org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.readArtifactDescriptor (DefaultArtifactDescriptorReader.java:171)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.resolveCachedArtifactDescriptor (DefaultDependencyCollector.java:541)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.getArtifactDescriptorResult (DefaultDependencyCollector.java:524)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (DefaultDependencyCollector.java:412)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (DefaultDependencyCollector.java:365)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.process (DefaultDependencyCollector.java:352)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.doRecurse (DefaultDependencyCollector.java:509)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (DefaultDependencyCollector.java:461)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (DefaultDependencyCollector.java:365)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.process (DefaultDependencyCollector.java:352)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.doRecurse (DefaultDependencyCollector.java:509)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (DefaultDependencyCollector.java:461)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (DefaultDependencyCollector.java:365)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.process (DefaultDependencyCollector.java:352)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.doRecurse (DefaultDependencyCollector.java:509)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (DefaultDependencyCollector.java:461)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (DefaultDependencyCollector.java:365)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.process (DefaultDependencyCollector.java:352)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.doRecurse (DefaultDependencyCollector.java:509)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (DefaultDependencyCollector.java:461)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (DefaultDependencyCollector.java:365)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.process (DefaultDependencyCollector.java:352)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.doRecurse (DefaultDependencyCollector.java:509)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (DefaultDependencyCollector.java:461)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (DefaultDependencyCollector.java:365)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.process (DefaultDependencyCollector.java:352)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.doRecurse (DefaultDependencyCollector.java:509)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (DefaultDependencyCollector.java:461)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (DefaultDependencyCollector.java:365)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.process (DefaultDependencyCollector.java:352)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.doRecurse (DefaultDependencyCollector.java:509)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (DefaultDependencyCollector.java:461)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (DefaultDependencyCollector.java:365)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.process (DefaultDependencyCollector.java:352)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.doRecurse (DefaultDependencyCollector.java:509)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (DefaultDependencyCollector.java:461)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.processDependency (DefaultDependencyCollector.java:365)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.process (DefaultDependencyCollector.java:352)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies (DefaultDependencyCollector.java:254)
    at org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies (DefaultRepositorySystem.java:284)
    at org.apache.maven.project.DefaultProjectDependenciesResolver.resolve (DefaultProjectDependenciesResolver.java:169)
    at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies (LifecycleDependencyResolver.java:243)
    at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies (LifecycleDependencyResolver.java:147)
    at org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved (MojoExecutor.java:248)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:202)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
    at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:498)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)

Checklist

Following this checklist to help us incorporate your
contribution quickly and easily:

Make sure there is a JIRA issue filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
Each commit in the pull request should have a meaningful subject line and body.
Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
where you replace MNG-XXX with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Run mvn clean verify to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.

michael-o · 2019-12-13T12:20:13Z

This would require an JIRA issue because you have found an obvious bug. How did you find it?

Tibor17 · 2019-12-13T12:36:18Z

@sadhen

Is this NPE a blocker?

@michael-o
We cannot release 3.6.4 due to a431794
Only a branch is possible.

michael-o · 2019-12-13T12:37:10Z

@sadhen

Is this NPE a blocker?

@michael-o
We cannot release 3.6.4 due to a431794
Only a branch is possible.

we can branch off 3.6.x.

da-liii · 2019-12-13T13:19:59Z

@michael-o

I have attached the stack trace.

Sorry for the rush pull request, since it is Friday night.

I tried to write a reproducer but failed for several attempts.

rfscholte · 2020-04-25T19:26:34Z

I have my doubt that this is the bug. I would love to see a failing test first.

slachiewicz · 2020-04-25T19:53:57Z

yes, it's bug - simple pom.xml to reproduce the problem locally

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
 xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
 <modelVersion>4.0.0</modelVersion>

<groupId>test</groupId>
 <artifactId>test</artifactId>
 <version>1.0</version>

<properties>
 <aa>${bb}</aa>
 <bb>${aa}</bb>
</properties>

</project>

rfscholte · 2020-04-25T19:56:34Z

Can you make a unittest for it?

slachiewicz · 2020-04-25T20:53:33Z

sure - https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=9c46b06bfc080ad51d2d5626114f47293693d05c

DarioRomano · 2020-05-14T13:44:05Z

I've also run into this issue when I added an xtext dependency to my build. It seems to be having troubles resolving transitive dependencies.

olamy · 2020-05-20T10:50:36Z

easy null check. Thanks for that!

Closes #301

jdillon · 2021-06-21T19:46:29Z

Any reason why this was not back-ported to 3.8.x?

Also this change only guards visit( Properties properties ) why does it not guard visit( List<String> list ) in the same way? Isn't the spirit of maven interpolation to leave the value asis if it couldn't interpolate anything? Though my memory on what its supposed to be done is a bit fuzzy.

michael-o · 2021-06-21T20:26:09Z

Any reason why this was not back-ported to 3.8.x?

Also this change only guards visit( Properties properties ) why does it not guard visit( List<String> list ) in the same way? Isn't the spirit of maven interpolation to leave the value asis if it couldn't interpolate anything? Though my memory on what its supposed to be done is a bit fuzzy.

3.8.x will be assessed after 4.0.0-alpha-1.

michael-o · 2021-06-21T20:45:12Z

Any reason why this was not back-ported to 3.8.x?

Also this change only guards visit( Properties properties ) why does it not guard visit( List<String> list ) in the same way? Isn't the spirit of maven interpolation to leave the value asis if it couldn't interpolate anything? Though my memory on what its supposed to be done is a bit fuzzy.

Please leave a note in the ticket.

Closes #301

jira-importer · 2025-07-06T15:57:34Z

Resolve #8649

碎镜 added 2 commits December 13, 2019 20:07

Fix NullPointerException

021ee24

re-formatting

ca9eddf

Tibor17 reviewed Dec 13, 2019

View reviewed changes

Comment thread ...ilder/src/main/java/org/apache/maven/model/interpolation/StringVisitorModelInterpolator.java Outdated

Simplify

f81cb57

da-liii requested a review from Tibor17 December 13, 2019 13:24

da-liii changed the title ~~(minor) Fix NullPointerException~~ [MNG-6819] Fix NullPointerException Dec 13, 2019

da-liii changed the title ~~[MNG-6819] Fix NullPointerException~~ [MNG-6819] Fix NullPointerException in StringVisitorModelInterpolator$ModelVisitor Dec 13, 2019

slachiewicz approved these changes Apr 25, 2020

View reviewed changes

He-Pin reviewed May 11, 2020

View reviewed changes

Comment thread ...ilder/src/main/java/org/apache/maven/model/interpolation/StringVisitorModelInterpolator.java

olamy approved these changes May 20, 2020

View reviewed changes

michael-o approved these changes May 20, 2020

View reviewed changes

asfgit pushed a commit that referenced this pull request May 22, 2020

[MNG-6819] Fix NullPointerException in StringVisitorModelInterpolator

fa20fb4

Closes #301

asfgit closed this in 14c9e15 May 23, 2020

asfgit pushed a commit that referenced this pull request Jun 21, 2020

[MNG-6819] Fix NullPointerException in StringVisitorModelInterpolator

2df6101

Closes #301

asfgit pushed a commit that referenced this pull request Jun 26, 2021

[MNG-6819] Fix NullPointerException in StringVisitorModelInterpolator

2f144de

Closes #301

Conversation

da-liii commented Dec 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Desc

Checklist

Uh oh!

michael-o commented Dec 13, 2019

Uh oh!

Uh oh!

Tibor17 commented Dec 13, 2019

Uh oh!

michael-o commented Dec 13, 2019

Uh oh!

da-liii commented Dec 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfscholte commented Apr 25, 2020

Uh oh!

slachiewicz commented Apr 25, 2020

Uh oh!

rfscholte commented Apr 25, 2020

Uh oh!

slachiewicz commented Apr 25, 2020

Uh oh!

Uh oh!

DarioRomano commented May 14, 2020

Uh oh!

olamy commented May 20, 2020

Uh oh!

jdillon commented Jun 21, 2021

Uh oh!

michael-o commented Jun 21, 2021

Uh oh!

michael-o commented Jun 21, 2021

Uh oh!

jira-importer commented Jul 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

da-liii commented Dec 13, 2019 •

edited

Loading

da-liii commented Dec 13, 2019 •

edited

Loading