Simplify detection of the MAVEN_HOME and make it fully qualified#307
Simplify detection of the MAVEN_HOME and make it fully qualified#307rostidev wants to merge 1 commit intoapache:masterfrom
Conversation
|
Thank you for contribution - could you also create Jira here: https://issues.apache.org/jira/browse/MNG ? |
|
Created a Jira issue about this improvement: |
slachiewicz
left a comment
There was a problem hiding this comment.
looks good to me, anyone else can check also?
|
I want to change this line in my commit: into this one: The reason: it's safer because theoretically the "\bin\" substring could appear more than once but we need to remove only the last one. I will amend my commit and push force it. |
The removed 'stripMHome' recursive function is not needed anymore. Part of the 'mvn -version' output before this change: Maven home: D:\develop\apache-maven-3.6.3\bin\.. Same part of the 'mvn -version' output after this change: Maven home: D:\develop\apache-maven-3.6.3 I.e. now it's fully qualified.
|
Quick question - what form where we use |
|
I just kept the original style of using https://stackoverflow.com/questions/535975/dealing-with-quotes-in-windows-batch-scripts |
…lified on Windows The removed 'stripMHome' recursive function is not needed anymore This closes #307
…lified on Windows The removed 'stripMHome' recursive function is not needed anymore This closes #307
|
Resolve #8451 |
The removed 'stripMHome' recursive function is not needed anymore.
Part of the 'mvn -version' output before this change:
Maven home: D:\develop\apache-maven-3.6.3\bin..
Same part of the 'mvn -version' output after this change:
Maven home: D:\develop\apache-maven-3.6.3
I.e. now it's fully qualified.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MNG-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.