[MNG-4660] --resume-from flag resolves inter-module dependencies#325
Merged
rfscholte merged 20 commits intoapache:masterfrom Apr 14, 2020
Merged
[MNG-4660] --resume-from flag resolves inter-module dependencies#325rfscholte merged 20 commits intoapache:masterfrom
rfscholte merged 20 commits intoapache:masterfrom
Conversation
…ndency resolving.
eolivelli
reviewed
Feb 14, 2020
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
Thanks for contributing this fix.
Can we add unit tests?
Do you have also new integration tests?
Contributor
Author
|
Forgot to mention, we actually started with an integration test: apache/maven-integration-testing #54. |
…fact is not up-to-date.
…ewer class files when checking if the packaged artifact is up-to-date
…not have a compile lifecycle when reading local artifacts. This is needed for resolving intermodule dependencies which are not built in this session (for example with -rf, -pl flags).
It now properly distinguishes between two situations: 1. project artifact has been built during earlier Maven session 2. project artifact has been built during this session
…lidate" by checking if the project consists in the reactor.
…ed to avoid a bug in JDK8 on linux.
…ackaged artifact is up to date.
|
Resolve #6417 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your contribution quickly and easily:
MNG-4660.
[MNG-XXX] - Fixes bug in ApproximateQuantiles, where you replaceMNG-XXXwith the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.This pull request makes sure that the
ReactorReaderlooks at all modules in the project, not only those that are part of the reactor. It also checks whether the workspace might contain built artifacts from earlier Maven invocations, and uses those files for the artifacts that they belong to.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.Additionally, there is an extra integration test in maven-integration-testing: apache/maven-integration-testing #54.
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.
ICLA has been signed by @MartinKanters and myself. CCLA has been signed by our employer, Info Support.