[MNG-7068] - Manage Google Guava dependency independent#426
Closed
boris-unckel wants to merge 1 commit intoapache:masterfrom
Closed
[MNG-7068] - Manage Google Guava dependency independent#426boris-unckel wants to merge 1 commit intoapache:masterfrom
boris-unckel wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@michael-o This is the corresponding PR to apache/maven-resolver#86 Unfortunately a unrelated checkstyle fails. Could you please check and give an advise? Thanks in advance. |
boris-unckel
force-pushed
the
MNG-7068_google_guice_guava_deps
branch
from
23544df to
3db2e05
Compare
Member
|
Merged. |
|
Resolve #7971 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MNG-7068
The proposal is first to add com.google.guava:guava to the excludes of guice. Second guava and failureaccess shall be added as direct dependencies.
This has two advantages: Downstream projects only get the needed dependencies and the version of guava can be independently set.
The runtime dependencies for Guava are explained in the last section of the README "Important Warnings" #3
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically. (org.apache.maven.xml.Factories checkstyle fail. Not related to this PR)
ICLA signed and send to the secretary.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.