[MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log#437
[MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log#437McFoggy wants to merge 1 commit intoapache:masterfrom
Conversation
|
Hi @McFoggy , isnt only Log which shouldn't be deprecated and the implementation can stay deprecated if we want to forward them to slf4j internally - I suspect we will want to do it in DefaultLog but for now it uses plexus which is not desired anymore from what I understood? |
|
Hi Romain,
I hesitated on this. I can switch it back for the 2 implementations if it is more aligned with the long term goal. |
|
@McFoggy not a big blocker for me since removing the deprecation on Log is the "big thing" there IMHO but think it is worth to have an implementation not deprecated (maybe default only?). |
|
One short notice - Plexus logger Log here, api and implementation is from Eclipse Plexus Sisu |
Sorry @slachiewicz I do not get your point. |
|
Sorry, that should be comment to other PR |
|
@rmannibucau finally I only removed depreciation on |
rfscholte
left a comment
There was a problem hiding this comment.
Maybe even add explicitly that by using this API, Maven is free to choose another logging framework at any time. Using Log will ensure the plugin will keep working.
|
I consider it barely realistic to remove SLF4J API in Core and replace it with something else. All components will fail anyway, Wagon, SCM, Shared, etc. This is just too short sighted. |
|
Proposal to supersede this #565 |
|
Resolve #7968 |
as discussed in the dev mailing list [1][2] this PR removes depreciation on
org.apache.maven.plugin.logging.LogFollowing this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MNG-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
Two unrelatd ITs tests are failing locally
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.