[MNG-7103] Make VersionScheme a component#449
Closed
cstamas wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Instead to ad-hoc create the instance as needed, it is thread safe, so is fine to have it shared across whole system. Moreover, touched class got converted from ancient plexus-field-like injection to proper immutable components, something we really need start doing
michael-o
reviewed
Feb 20, 2021
Member
michael-o
left a comment
michael-o
left a comment
There was a problem hiding this comment.
This one deserves a JIRA issue.
cstamas
changed the title
michael-o
reviewed
May 2, 2021
| */ | ||
| @Named | ||
| @Singleton | ||
| public class VersionSchemeProvider |
Member
There was a problem hiding this comment.
Why do we need this provider If GenericVersionScheme is properly annotated? Where is it used?
Member
Author
There was a problem hiding this comment.
Need to review this and refresh my memory. But the idea was to have some sort of indirection, if we want to introduce other kind than "generic" version support... Consider this PR as draft pls
Member
Author
|
Obsolete, replaced by #563 |
|
Resolve #8346 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MNG-7103: Instead to ad-hoc create the instance as needed, it is thread safe,
so is fine to have it shared across whole system.
Moreover, touched classes got converted from ancient plexus-field-like
injection to proper immutable components, something we really need
start doing.
Full conversion (of resolver classes) will become possible once ServiceLocator dropped
(see MRESOLVER-157).
Also, the idea of MNG-7104 that a "touched" (changed) class become refactored to ctor injection as well.