[MNG-7173] The maven-resolver-provider:MavenResolverModule is broken#479
Closed
[MNG-7173] The maven-resolver-provider:MavenResolverModule is broken#479
Conversation
It is broken since 3.6.2 or so, when ModelBuilder got decorated with JSR330 injections, that work in sisu but not in Guice as it needs explicit bindings added. This is an UT that proves that module is incomplete.
Member
Author
|
As expected, newly added UT fails: |
Member
Author
|
Related: after https://issues.apache.org/jira/browse/MNG-6685 the Guice module was not updated. |
Member
Author
|
Test will pass, but not done yet: module is getting huge, so probably needs some refactoring, maybe splitting them into several parts (and allow overrides). |
Member
Author
|
This PR is defunct, Guice modules were removed in #1282 |
|
Resolve #8282 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is broken since 3.6.2 or so, when ModelBuilder got decorated with
JSR330 injections, that work in sisu but not in Guice as it needs
explicit bindings added.
This is an UT that proves that module is incomplete.