[MNG-7182] Use a pull parser during the build/consumer transformation

[gnodet]

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace MNG-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[michael-o]

I think this needs a JIRA issue.

[gnodet]

There's a single test failing on windows + jdk 1.8. Does that ring any bell @rfscholte ?
https://github.com/apache/maven/pull/486/checks?check_run_id=3016896271#step:8:6012

[michael-o]

There's a single test failing on windows + jdk 1.8. Does that ring any bell @rfscholte ?
https://github.com/apache/maven/pull/486/checks?check_run_id=3016896271#step:8:6012

Bad code, concurrent write access, Windows file locking.

[rfscholte]

That would be my guess too

[rfscholte]

It is a bit weird that this IT is using an external plugin for verification. First step would be to update the version of the flatten-maven-plugin. Maybe in the future we need to reconsider rewriting this IT.

[MartinKanters]

The business logic is new to me and I'm not too experienced with XML transformation. I didn't see any red flags, but perhaps @rfscholte for example can take a better look at that? My review is more focused on small coding things. Nice job on the performance boost!

[gnodet]

@rfscholte could you please review, I think that one is important to include in master asap to avoid the performance loss in the first alpha.
There's still this small problem on windows + jdk8 (file lock still in place) which I've worked around by using a fork + timeout in the tests, but It does not appear on any other combination and I've been unable to find a place where a file lock would be kept. In addition, I haven't been able to reproduce it in a real environment.

[rfscholte]

Just ran the branch on Jenkins, it is unstable: https://ci-maven.apache.org/blue/organizations/jenkins/Maven%2Fmaven-box%2Fmaven/detail/MNG-7182/1/tests
One thing I notice is that it looks like the linebreaks around the license are better compared to what I could do. Please also provide a PR for that.

[gnodet]

Just ran the branch on Jenkins, it is unstable: https://ci-maven.apache.org/blue/organizations/jenkins/Maven%2Fmaven-box%2Fmaven/detail/MNG-7182/1/tests
One thing I notice is that it looks like the linebreaks around the license are better compared to what I could do. Please also provide a PR for that.

Yes, it took me a bit of time to get that right ;-)
I'll have a look at those tests, I thought I did modify them to pass.

[gnodet]

Just ran the branch on Jenkins, it is unstable: https://ci-maven.apache.org/blue/organizations/jenkins/Maven%2Fmaven-box%2Fmaven/detail/MNG-7182/1/tests
One thing I notice is that it looks like the linebreaks around the license are better compared to what I could do. Please also provide a PR for that.

Yes, it took me a bit of time to get that right ;-)
I'll have a look at those tests, I thought I did modify them to pass.

I fixed and squashed the PRs.

[cstamas]

Re Caused by: java.lang.NoSuchMethodError: org.apache.maven.plugin.PluginParameterExpressionEvaluator.<init> see here #562 (comment)
Do you have some ancient enforcer? Or comment is wrong and there is something else (ancient) using this ctor?

[cstamas]

Re Caused by: java.lang.NoSuchMethodError: org.apache.maven.plugin.PluginParameterExpressionEvaluator.<init> see here #562 (comment) Do you have some ancient enforcer? Or comment is wrong and there is something else (ancient) using this ctor?

Hm, but something is wrong, it WAS ancient and is already upped apache/maven-integration-testing#115

[cstamas]

Hm, but something is wrong, it WAS ancient and is already upped apache/maven-integration-testing#115

Eh, update your fork please https://github.com/gnodet/maven-integration-testing (master on apache/maven-integration-testing contains fixes for you: upped enforcer)

[gnodet]

Hm, but something is wrong, it WAS ancient and is already upped apache/maven-integration-testing#115

Eh, update your fork please https://github.com/gnodet/maven-integration-testing (master on apache/maven-integration-testing contains fixes for you: upped enforcer)

Thx, I've rebased both PRs on top of master, which looks much better indeed !

[gnodet]

I'd like to get that in master to avoid the big performance loss. Anyone could take a look ?

[rmannibucau]

(LGTM, the very minor note can be to write a one sentence description in the ticket since it lacks some context if anyone reviews it later ;))

[hboutemy]

@rfscholte do you see any drawback to using plexus-utils' XPP3?

[jira-importer]

Resolve #8266