Avoid mixing two flavours of Guice on the classpath.#5
Closed
mcculls wants to merge 1 commit intoapache:masterfrom
Closed
Avoid mixing two flavours of Guice on the classpath.#5mcculls wants to merge 1 commit intoapache:masterfrom
mcculls wants to merge 1 commit intoapache:masterfrom
Conversation
Note: the main blocker to using Google-Guice for Maven3 is the lack of a release with the new ProvisionListener API, which is needed to support Plexus lifecycles. While there are other fixes/features in Sisu-Guice that are nice-to-have (such as removal of the big global singleton lock) they aren't strictly required for Maven3.
Contributor
Author
asfgit
pushed a commit
that referenced
this pull request
May 2, 2020
The wrapper script has detected a .mvn directory, so it would be better to assume that this is the location of the wrapper jar, rather than the current directory (.). This change could be enhanced by adding a separate detection loop for the jar itself as opposed to the .mvn directory, but this is the smallest possible change that fixes the bug. Fixes gh-5
asfgit
pushed a commit
that referenced
this pull request
May 23, 2020
The wrapper script has detected a .mvn directory, so it would be better to assume that this is the location of the wrapper jar, rather than the current directory (.). This change could be enhanced by adding a separate detection loop for the jar itself as opposed to the .mvn directory, but this is the smallest possible change that fixes the bug. Fixes gh-5
asfgit
pushed a commit
that referenced
this pull request
Jun 21, 2020
The wrapper script has detected a .mvn directory, so it would be better to assume that this is the location of the wrapper jar, rather than the current directory (.). This change could be enhanced by adding a separate detection loop for the jar itself as opposed to the .mvn directory, but this is the smallest possible change that fixes the bug. Fixes gh-5
gnodet
pushed a commit
to gnodet/maven
that referenced
this pull request
Nov 20, 2024
|
Resolve #8244 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: the main blocker to using Google-Guice for Maven3 is the lack of a release with the new ProvisionListener API, which is needed to support Plexus lifecycles. While there are other fixes/features in Sisu-Guice that are nice-to-have (such as removal of the big global singleton lock) they aren't strictly required for Maven3.