Closed
Conversation
michael-o
reviewed
Sep 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a proposal to get rid of the
PlexusContainerinterface in maven. All the remaining references arenamaven-compat(which should hopefully be removed, see #552) and in the newmaven-containermodule. Theplexus-testingmodule has been switched to the test-jar from the new module which uses the new API.I think the idea would be to make
maven-containerit's own project so that it can be reused through other maven components, likemaven-resolver. A possible evolution is to completely get rid ofsisu-plexusand implement it inside this newmaven-containerproject, but that's definitely out of scope for this PR.