Skip to content

[MNG-7391] Fix MojosExecutionStrategy lookup to be able to look into the SessionScope#692

Merged
gnodet merged 1 commit intoapache:maven-3.9.xfrom
gnodet:mng-7391-lookup
Mar 15, 2022
Merged

[MNG-7391] Fix MojosExecutionStrategy lookup to be able to look into the SessionScope#692
gnodet merged 1 commit intoapache:maven-3.9.xfrom
gnodet:mng-7391-lookup

Conversation

@gnodet
Copy link
Copy Markdown
Contributor

@gnodet gnodet commented Mar 14, 2022

No description provided.

@laeubi
Copy link
Copy Markdown
Contributor

laeubi commented Mar 14, 2022

This looks good even though I'm not that familiar with how providers work, will this lookup on each request (so you get the highest component freshyl on the call) or do it cache it once requested?

@gnodet
Copy link
Copy Markdown
Contributor Author

gnodet commented Mar 14, 2022

The component is cached by its scope. When m-build-cache-e is not active, it's @Singleton and when it's active, it's the @SessionScope. In both cases, that's fine, as the build cache extension does everything in the session scope anyway.

@gnodet gnodet merged commit 3a5a40c into apache:maven-3.9.x Mar 15, 2022
@laeubi
Copy link
Copy Markdown
Contributor

laeubi commented Mar 15, 2022

@gnodet @michael-o just wondering, would this maybe a good candidate for a maven-3.8.6 or are there no bug-fix releases for maven?

@gnodet
Copy link
Copy Markdown
Contributor Author

gnodet commented Mar 15, 2022

@laeubi the MojosExecutionStrategy has been introduced in 3.9.x and 4.0.x, but it's not present in 3.8.x branch.

@laeubi
Copy link
Copy Markdown
Contributor

laeubi commented Mar 15, 2022

Alright, I forget about this :-)

@jira-importer
Copy link
Copy Markdown

Resolve #9173

@olamy olamy mentioned this pull request Apr 2, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants