Skip to content

Version ranges with non-snapshot bounds can contain snapshot versions #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kunalsomani wants to merge 1 commit into from
Closed

Version ranges with non-snapshot bounds can contain snapshot versions #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions ...vider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ public class DefaultVersionRangeResolver
{

private static final String MAVEN_METADATA_XML = "maven-metadata.xml";


private static final String SNAPSHOT = "SNAPSHOT";

@SuppressWarnings( "unused" )
@Requirement( role = LoggerFactory.class )
private Logger logger = NullLoggerFactory.LOGGER;
Expand Down Expand Up @@ -254,10 +256,20 @@ private Map<String, ArtifactRepository> getVersions( RepositorySystemSession ses
Versioning versioning = readVersions( session, trace, metadataResult.getMetadata(), repository, result );
for ( String version : versioning.getVersions() )
{
if ( !versionIndex.containsKey( version ) )
{
versionIndex.put( version, repository );
}
if(request.getArtifact().getVersion().toUpperCase().contains(SNAPSHOT)){
if ( !versionIndex.containsKey( version ) )
{
versionIndex.put( version, repository );
}
}
else{
if(!version.toUpperCase().contains(SNAPSHOT)){
if ( !versionIndex.containsKey( version ) )
{
versionIndex.put( version, repository );
}
}
}
}
}

Expand Down