[MNG-7455] Another attempt to fix the concurrency issue#716
Closed
gnodet wants to merge 2 commits intoapache:maven-3.9.xfrom
Closed
[MNG-7455] Another attempt to fix the concurrency issue#716gnodet wants to merge 2 commits intoapache:maven-3.9.xfrom
gnodet wants to merge 2 commits intoapache:maven-3.9.xfrom
Conversation
Contributor
I found especially this rather annoying, as one has to use the Legacy Support to get the "current" session. |
Contributor
Author
|
|
Resolve #9008 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another attempt to fix the concurrency issue with minimal changes and without introducing back a thread local storage.
The downside of this proposal is that components annotated with
@SessionScopedwill always be injected the root session, which imho, is not really a problem as all derived sessions are cloned from the root one, except for the value of theMavenSession#getCurrentProject()which changes from one session to another.The current scope is flawed anyway, as components are clearly not cached for all derived sessions, which was the original point of MNG-7347.