Skip to content

[MNG-7453] Upgrade Maven Resolver to 1.8.0 in maven-4.x #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cstamas wants to merge 1 commit into from
Closed

[MNG-7453] Upgrade Maven Resolver to 1.8.0 in maven-4.x #719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,19 @@ under the License.
<url>https://maven.apache.org/ref/${project.version}/</url>
<inceptionYear>2001</inceptionYear>

<repositories>
<repository>
<id>repository.apache.org</id>
<url>https://repository.apache.org/content/repositories/snapshots</url>
<releases>
<enabled>false</enabled>
</releases>
<snapshots>
<enabled>true</enabled>
</snapshots>
</repository>
</repositories>
Comment on lines +48 to +59
Copy link
Copy Markdown
Member

@slawekjaranowski slawekjaranowski Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is in ASF pom ....
https://github.com/apache/maven-apache-parent/blob/master/pom.xml#L110-L129
Is it not the same?

Copy link
Copy Markdown
Member Author

@cstamas cstamas Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh, missed it :) I assumed maven build does not allow snapshots for some reason (and CI builds w/ snapshots would fail)

Copy link
Copy Markdown
Member Author

@cstamas cstamas Apr 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I remember what I mixed up: not snapshot artifacts, but staged artifacts....


<properties>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
Expand All @@ -65,7 +78,7 @@ under the License.
<cipherVersion>2.0</cipherVersion>
<modelloVersion>2.0.0</modelloVersion>
<jxpathVersion>1.3</jxpathVersion>
<resolverVersion>1.7.3</resolverVersion>
<resolverVersion>1.8.0-SNAPSHOT</resolverVersion>
<slf4jVersion>1.7.32</slf4jVersion>
<xmlunitVersion>2.6.4</xmlunitVersion>
<maven.test.redirectTestOutputToFile>true</maven.test.redirectTestOutputToFile>
Expand Down