Skip to content

[MNG-7433] Warn if in parallel build aggregator Mojo found #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cstamas wants to merge 2 commits into from
Closed

[MNG-7433] Warn if in parallel build aggregator Mojo found #729

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1df04cf
[MNG-7433] Warn if in parallel build aggregator Mojo found
cstamas Apr 27, 2022
1df15cb
Move log into locked region, add proper message.
cstamas Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@
import org.apache.maven.project.MavenProject;
import org.codehaus.plexus.util.StringUtils;
import org.eclipse.aether.SessionData;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/**
* <p>
Expand All @@ -75,10 +77,14 @@
@Singleton
public class MojoExecutor
{
private static final Logger LOGGER = LoggerFactory.getLogger( MojoExecutor.class );

private final BuildPluginManager pluginManager;

private final MavenPluginManager mavenPluginManager;

private final LifecycleDependencyResolver lifeCycleDependencyResolver;

private final ExecutionEventCatapult eventCatapult;

private final ReadWriteLock aggregatorLock = new ReentrantReadWriteLock();
Expand Down Expand Up @@ -225,6 +231,16 @@ private void execute( MavenSession session, MojoExecution mojoExecution, Project

try ( ProjectLock lock = new ProjectLock( session, mojoDescriptor, aggregatorLock ) )
{
if ( session.isParallel() && mojoDescriptor.isAggregator() )
{
LOGGER.warn( "===" );
LOGGER.warn( "Executing aggregator Mojo in parallel build:" );
LOGGER.warn( "Aggregator Mojo requires exclusive access to reactor, " );
LOGGER.warn( "to prevent race conditions, an aggregating execution will block" );
LOGGER.warn( "all other executions until finished." );
LOGGER.warn( "===" );
}

doExecute( session, mojoExecution, projectIndex, dependencyContext );
}
}
Expand Down