[MNG-7433] Warn if in parallel build aggregator Mojo found

[gnodet]

No description provided.

[cstamas]

Just FYI: this would need to go in all branches, not just master, where the lock is present, so 3.8.x, 3.9.x and master.

[michael-o]

I would expect the message to look similar to this:

maven/maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java

Lines 144 to 152 in faf5d5d

	logger.warn( "*****************************************************************" );
	logger.warn( "* Your build is requesting parallel execution, but project *" );
	logger.warn( "* contains the following plugin(s) that have goals not marked *" );
	logger.warn( "* as @threadSafe to support parallel building. *" );
	logger.warn( "* While this /may/ work fine, please look for plugin updates *" );
	logger.warn( "* and/or request plugins be made thread-safe. *" );
	logger.warn( "* If reporting an issue, report it against the plugin in *" );
	logger.warn( "* question, not against maven-core *" );
	logger.warn( "*****************************************************************" );

[michael-o]

Please create a separate ticket for this.

Question: I guess this must also go into 3.9.0 and master?

[gnodet]

Please create a separate ticket for this.

For what exactly ? The terminal width thing ? You'd prefer the terminal width adjustment to be only in 3.9.x / master ?

Question: I guess this must also go into 3.9.0 and master?

Yes, the warning should be in all 3 supported branches.

Fwiw, I've committed the improvement with the terminal width. The thread safety warning now looks like the following in my terminal:

[INFO] -----------------------< org.apache.maven:maven >-----------------------
[INFO] Building Apache Maven 3.8.6-SNAPSHOT                              [1/15]
[INFO] --------------------------------[ pom ]---------------------------------
[WARNING] *******************************************************************************************************************************************************************
[WARNING] * Your build is requesting parallel execution, but project contains the following plugin(s) that have goals not marked as @threadSafe to support parallel         *
[WARNING] * building.                                                                                                                                                       *
[WARNING] * While this /may/ work fine, please look for plugin updates and/or request plugins be made thread-safe.                                                          *
[WARNING] * If reporting an issue, report it against the plugin in question, not against maven-core.                                                                        *
[WARNING] *******************************************************************************************************************************************************************
[WARNING] The following plugins are not marked @threadSafe in Apache Maven:
[WARNING]   - org.apache.rat:apache-rat-plugin:0.13
[WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.
[WARNING] *******************************************************************************************************************************************************************
[INFO] 

Btw, having maven displaying such warnings during its own build... !!

[gnodet]

I wonder if it wouldn't be better to fix enhance the ExecutionEventLogger at the same time, the one that displays:

[INFO] -----------------------< org.apache.maven:maven >-----------------------
[INFO] Building Apache Maven 3.8.6-SNAPSHOT                              [1/15]
[INFO] --------------------------------[ pom ]---------------------------------

[michael-o]

Please create a separate ticket for this.

For what exactly ? The terminal width thing ? You'd prefer the terminal width adjustment to be only in 3.9.x / master ?

For the logging message and its intent in 3.8.x, 3.9.x and master. The goal is to show the user in the changelog that such a warning in this specific case is being implemented. Then MNG-7433 will partially be addressed through this log message and user requirement to restructure code/layout of project.

[gnodet]

I've raised #736 with a new JIRA issue for the warning.
The terminal width layout does not really make sense unless the default logging also adapts, I'll raise a JIRA for that and will provide a PR for 3.9.x / master.

[jira-importer]

Resolve #9026