[MNG-7353] support CLI "mvn pluginPrefix:version:goal"

[hboutemy]

https://issues.apache.org/jira/browse/MNG-7353

[michael-o]

I don't think we can make this assumption for sure since for testing or other reasong the groupId could be: foo, bar-baz

[hboutemy]

if you want to test a plugin for such simplified run, just don't define such a groupId
at least, it seems to work for real world plugins, that's the first intent

of course, if you find a better heuristics, or even an algorithm, I'm all ears open

[mthmulders]

I gave it some thought, but I can't find a better heuristic either. The only thing more or less foolproof would be to look at the first token, assuming it is a plugin prefix. If that lookup yields nothing, it would be a groupId.

Even that is not 100% safe, though. Imagine you're not connected to the network, so lookup fails, so we decide it's a groupId -- this certainly doesn't make sense. But more importantly, it's probably quite costly compared to a String.contains :-).

[hboutemy]

and do you really think that we'll have any single word groupId in the future, given Maven Central explicitely asks for DNS matching?
heuristics is heuristics: in theory there could be edge cases, but in real world, it simply works

[kelunik]

This indeed breaks real-world projects. We're using a single word groupId internally and invoking maven using mvn groupId:artifactId:goal@executionId no longer works starting with Maven 3.8.8.

[mthmulders]

I like this feature a lot. Would it be possible to add an IT for it?

[michael-o]

I like this feature a lot. Would it be possible to add an IT for it?

I second that.

[hboutemy]

IT added, that checks every CLI goal invocation format (with or without executionId)

mng7353 CliGoalInvocation.PrefixGoal()....................... OK (0.4 s)
mng7353 CliGoalInvocation.GroupIdArtifactIdVersionGoalAtId(). OK (0.3 s)
mng7353 CliGoalInvocation.PrefixVersionGoal()................ OK (0.3 s)
mng7353 CliGoalInvocation.GroupIdArtifactIdVersionGoal()..... OK (0.3 s)
mng7353 CliGoalInvocation.PrefixVersionGoalAtId()............ OK (0.3 s)
mng7353 CliGoalInvocation.PrefixGoalAtId()................... OK (0.3 s)
mng7353 CliGoalInvocation.GroupIdArtifactIdGoal()............ OK (0.3 s)
mng7353 CliGoalInvocation.GroupIdArtifactIdGoalAtId()........ OK (0.3 s)

please review
(notice: PR CI build does not seem to detect the associate core ITs branch...)

[mthmulders]

Thanks for the IT. I've learned about mvn <pluginPrefix>:<goal>@<id> today :-)

Since there's no PR for the IT, let me ask one question here: I noticed the name of the test methods all start with test, but there's no @Test annotation. I thought we were on JUnit 4, with JUnit 5 underway. Wouldn't it make more sense to write the tests in JUnit 4 style? Also, if we were on JUnit 5 already, you could even turn it into a parameterised test, but I think that's not possible at the moment.

[mthmulders]

(notice: PR CI build does not seem to detect the associate core ITs branch...)

Looking at the CI job for this PR, I see it detected the branch in m-i-t correctly and ran the new tests correctly:

[michael-o]

Will test this week...

[hboutemy]

on Junit 4 vs 5: I'm not a purist, I just copied from others, it's so basic :)

[michael-o]

All good. I have already rebased and cleaned up for you. You just need to merge! Allez !

[jira-importer]

Resolve #8080