Skip to content

[MNG-7520] Simplify integration of Redisson and Hazelcast for Maven R…#776

Merged
asfgit merged 1 commit intomasterfrom
MNG-7520
Aug 23, 2022
Merged

[MNG-7520] Simplify integration of Redisson and Hazelcast for Maven R…#776
asfgit merged 1 commit intomasterfrom
MNG-7520

Conversation

@michael-o
Copy link
Copy Markdown
Member

…esolver

This closes #776

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY, where you replace MNG-XXX
    and SUMMARY with the appropriate JIRA issue. Best practice is to use the JIRA issue
    title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@michael-o michael-o requested a review from cstamas July 23, 2022 22:13
@michael-o michael-o marked this pull request as ready for review July 23, 2022 22:29
@michael-o
Copy link
Copy Markdown
Member Author

@jebeaudet have a look

deutschebank-sync pushed a commit to deutschebank/maven that referenced this pull request Jul 23, 2022
@cstamas
Copy link
Copy Markdown
Member

cstamas commented Jul 29, 2022

Am unsure about the "worthiness" of this PR.... I mean, will someone really want to use Hazelcast AND Redisson?
IMHO, this is -0 as am pretty sure people will "stick" to one or another, and also, there is file locking...

@michael-o
Copy link
Copy Markdown
Member Author

michael-o commented Jul 29, 2022

Am unsure about the "worthiness" of this PR.... I mean, will someone really want to use Hazelcast AND Redisson? IMHO, this is -0 as am pretty sure people will "stick" to one or another, and also, there is file locking...

It is not about having BOTH in place. It shalls imply reduce manual setup and simplification of our documentation. Both are contained to handle both cases, NOT at the same time. Even for testing with a new Maven version I have to perform these stupid manual tests over and over again.

@michael-o
Copy link
Copy Markdown
Member Author

Note that this does not include any JARs, just the skeleton to make it happen.


[plexus.core]
load ${maven.conf}/logging
optionally ${maven.home}/lib/ext/redisson/*.jar
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Comment thread apache-maven/src/assembly/maven/lib/ext/hazelcast/README.txt Outdated
Comment thread apache-maven/src/assembly/maven/lib/ext/redisson/README.txt Outdated
Comment thread apache-maven/src/assembly/maven/lib/ext/hazelcast/README.txt Outdated
@michael-o
Copy link
Copy Markdown
Member Author

@cstamas how should I continue here? This is a reasonable simplification for everyone wants to use either one.

@michael-o
Copy link
Copy Markdown
Member Author

@cstamas Is my reasoning clear on this?

…esolver

Co-authored-by: Jacques-Etienne Beaudet <jebeaudet@gmail.com>

This closes #776
@asfgit asfgit closed this in e296400 Aug 23, 2022
@asfgit asfgit merged commit e296400 into master Aug 23, 2022
asfgit pushed a commit that referenced this pull request Aug 23, 2022
…esolver

Co-authored-by: Jacques-Etienne Beaudet <jebeaudet@gmail.com>

This closes #776
@michael-o michael-o deleted the MNG-7520 branch August 23, 2022 20:06
jebeaudet added a commit to jebeaudet/maven-resolver that referenced this pull request Feb 23, 2023
cstamas pushed a commit to apache/maven-resolver that referenced this pull request Feb 24, 2023
asfgit pushed a commit that referenced this pull request Mar 9, 2023
…esolver

Co-authored-by: Jacques-Etienne Beaudet <jebeaudet@gmail.com>

This closes #776
@jira-importer
Copy link
Copy Markdown

Resolve #8942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants