Skip to content

[MNG-7523] Backport MAVEN_ARGS support to 3.8.x#781

Merged
hgschmie merged 1 commit intoapache:maven-3.8.xfrom
hgschmie:MAVEN_ARGS
Jul 29, 2022
Merged

[MNG-7523] Backport MAVEN_ARGS support to 3.8.x#781
hgschmie merged 1 commit intoapache:maven-3.8.xfrom
hgschmie:MAVEN_ARGS

Conversation

@hgschmie
Copy link
Copy Markdown
Contributor

https://maven.apache.org/configure.html shows the MAVEN_ARGS
environment variable which is extremely useful for customizing build
scripts and processes. Unfortunately, it is only support for (unreleased)
Maven 4.

This patch backports support to Maven 3.8.x in the hope that this
support would arrive much sooner than with Maven 4.x.x

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY, where you replace MNG-XXX
    and SUMMARY with the appropriate JIRA issue. Best practice is to use the JIRA issue
    title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

... against the right branch this time ...

https://maven.apache.org/configure.html shows the MAVEN_ARGS
environment variable which is extremely useful for customizing build
scripts and processes. Unfortunately, it is only support for (unreleased)
Maven 4.

This patch backports support to Maven 3.8.x in the hope that this
support would arrive much sooner than with Maven 4.x.x
Copy link
Copy Markdown
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

@hgschmie hgschmie merged commit 25381b6 into apache:maven-3.8.x Jul 29, 2022
@hgschmie hgschmie deleted the MAVEN_ARGS branch July 29, 2022 18:39
hgschmie added a commit that referenced this pull request Jul 29, 2022
This feature was only intended for 3.9.x, not onto the 3.8.x branch.

This reverts commit 25381b6.
@jira-importer
Copy link
Copy Markdown

Resolve #9108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants