[MNG-5075] MavenProject.getParent throws undocumented ISE by jglick · Pull Request #8 · apache/maven

jglick · 2013-04-29T15:59:20Z

Fix for MNG-5075: MavenProject.getParent throws IllegalStateException when there is a model building error. Patch (updated version of JIRA original) just sends any problems to the logger and returns null, which is not great but is at least now documented and will prevent innocent clients from being fatally broken by an unchecked exception.

I am jglick@apache.org and intend this patch to be submitted to the ASF under the ASL 2.0.

jglick · 2013-04-29T16:03:23Z

mvn clean install test integration-test passes with this change.

jglick · 2013-04-29T16:14:02Z

Also did the following at @stephenc’s suggestion, in case that is more exacting:

rm -rf ~/.m2
M2_HOME=/tmp/maven ant all
/tmp/maven/bin/mvn clean install -Prun-its -B -U -V

which worked though

[WARNING] The requested profile "run-its" could not be activated because it does not exist.

Really there should be a pull request builder for this sort of thing, so I do not have to guess what tests you expect to be run!

olamy · 2013-05-02T11:00:05Z

to run integration test
git clone https://git-wip-us.apache.org/repos/asf/maven-integration-testing.git
cd maven-integration-testing
mvn clean install -Prun-its (with M2_HOME to your fresh maven core build or -DmavenHome=path to your maven core build)

jglick · 2013-05-06T22:47:05Z

I get the same errors from my branch as from the master commit it is based on:

Tests in error: 
  MavenITmng3983PluginResolutionFromProfileReposTest>AbstractMavenIntegrationTestCase.runTest:220->testitFromPom:58 » Verification
  MavenITmng3970DepResolutionFromProfileReposTest>AbstractMavenIntegrationTestCase.runTest:220->testitFromPom:78 » Verification
  MavenITmng3948ParentResolutionFromProfileReposTest>AbstractMavenIntegrationTestCase.runTest:220->testitFromPom:78 » Verification
  MavenITmng3652UserAgentHeaderTest>AbstractMavenIntegrationTestCase.runTest:220->testmng3652_UnConfiguredHttp:123 » Verification
  MavenITmng3652UserAgentHeaderTest>AbstractMavenIntegrationTestCase.runTest:220->testmng3652_UnConfiguredDAV:175 » Verification
  MavenITmng3372DirectInvocationOfPluginsTest>AbstractMavenIntegrationTestCase.runTest:220->testDependencyTreeInvocation:83 » Verification

Tests run: 716, Failures: 0, Errors: 6, Skipped: 0

Maybe due to my use of a *-mirror? Another reason to have a standard PR builder which is known to pass all trunk tests.

jglick · 2014-01-06T15:37:58Z

Claimed merged in 2eb419e.

…en-3.6.3 to MNG-7129/maven-3.6.3-incremental Squashed commit of the following: commit 21c620a34ddbbf84b3c44014b069a7b222cf91a7 Author: Maximilian Novikov <maximilian.novikov@db.com> Date: Tue Aug 10 19:41:41 2021 +0200 Merge pull request apache#3 in ABFX/maven-forked from code-cleanup-2 to incremental-maven-3.6.3 Squashed commit of the following: commit 3401739ec9eb957fb03887f6a3c24477c9c3327b Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Tue Aug 10 13:37:13 2021 -0400 cleanup db specifics commit 5d32f00559951445ecaf7d5ec4d847541c10e7e9 Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Tue Aug 10 11:05:28 2021 -0400 cleanup db specifics commit fcec28f82c0d447de64032c610b39fa75bb344b0 Merge: 6fd401af2 5b0dc1858 Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Mon Aug 9 13:22:16 2021 +0100 Pull request apache#9: Remote cache setup Merge in BND/maven-forked from feature/remote-cache-setup to incremental-maven-3.6.3 * commit '5b0dc1858cf4ca499502f0741b2f3bf2ac55530c': remote cache setup - fail fast, baseline build, diff reporting, documentation. commit 5b0dc1858cf4ca499502f0741b2f3bf2ac55530c Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Mon Mar 22 03:30:03 2021 +0100 remote cache setup - fail fast, baseline build, diff reporting, documentation. commit 6fd401af285692df568312ee66ee00edfe21f1cc Author: Maximilian Novikov <maximilian.novikov@db.com> Date: Tue Apr 13 17:36:49 2021 +0100 Pull request apache#8: Incremental Maven - added non-overrideable cache entries Merge in BND/maven-forked from non-overritable-build-info to incremental-maven-3.6.3 Squashed commit of the following: commit 405bbef8a59cabc0b83e9a64717f65fbd6fb9e3d Author: maximilian.novikov@db.com <maximilian.novikov@db.com> Date: Mon Apr 12 20:18:27 2021 +0200 Incremental Maven - added non-overrideable cache entries - review fixes commit 197704672756e558fb3521e16859d0be324044b8 Author: maximilian.novikov@db.com <maximilian.novikov@db.com> Date: Fri Apr 9 11:35:48 2021 +0200 Incremental Maven - added non-overrideable cache entries commit 64c4b1f5cbdf920ad43560f34cc5be56d4557acf Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Tue Mar 9 04:10:20 2021 +0100 injected version commit 727e507ae2fd90dce7011f3f1c76eb4969577d5e Author: maximilian.novikov@db.com <maximilian.novikov@db.com> Date: Wed Jan 13 16:17:25 2021 +0100 Incremental Maven - Java 11 fix commit b2f297566d5afcb0a285985cb5540685a28cafec Author: maximilian.novikov@db.com <maximilian.novikov@db.com> Date: Tue Jan 12 14:10:08 2021 +0100 Incremental Maven - initial commit

….3 to MNG-7129/maven-3.6.3-incremental Squashed commit of the following: commit 21c620a34ddbbf84b3c44014b069a7b222cf91a7 Author: Maximilian Novikov <maximilian.novikov@db.com> Date: Tue Aug 10 19:41:41 2021 +0200 Merge pull request #3 in ABFX/maven-forked from code-cleanup-2 to incremental-maven-3.6.3 Squashed commit of the following: commit 3401739ec9eb957fb03887f6a3c24477c9c3327b Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Tue Aug 10 13:37:13 2021 -0400 cleanup db specifics commit 5d32f00559951445ecaf7d5ec4d847541c10e7e9 Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Tue Aug 10 11:05:28 2021 -0400 cleanup db specifics commit fcec28f82c0d447de64032c610b39fa75bb344b0 Merge: 6fd401af2 5b0dc1858 Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Mon Aug 9 13:22:16 2021 +0100 Pull request #9: Remote cache setup Merge in BND/maven-forked from feature/remote-cache-setup to incremental-maven-3.6.3 * commit '5b0dc1858cf4ca499502f0741b2f3bf2ac55530c': remote cache setup - fail fast, baseline build, diff reporting, documentation. commit 5b0dc1858cf4ca499502f0741b2f3bf2ac55530c Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Mon Mar 22 03:30:03 2021 +0100 remote cache setup - fail fast, baseline build, diff reporting, documentation. commit 6fd401af285692df568312ee66ee00edfe21f1cc Author: Maximilian Novikov <maximilian.novikov@db.com> Date: Tue Apr 13 17:36:49 2021 +0100 Pull request #8: Incremental Maven - added non-overrideable cache entries Merge in BND/maven-forked from non-overritable-build-info to incremental-maven-3.6.3 Squashed commit of the following: commit 405bbef8a59cabc0b83e9a64717f65fbd6fb9e3d Author: maximilian.novikov@db.com <maximilian.novikov@db.com> Date: Mon Apr 12 20:18:27 2021 +0200 Incremental Maven - added non-overrideable cache entries - review fixes commit 197704672756e558fb3521e16859d0be324044b8 Author: maximilian.novikov@db.com <maximilian.novikov@db.com> Date: Fri Apr 9 11:35:48 2021 +0200 Incremental Maven - added non-overrideable cache entries commit 64c4b1f5cbdf920ad43560f34cc5be56d4557acf Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Tue Mar 9 04:10:20 2021 +0100 injected version commit 727e507ae2fd90dce7011f3f1c76eb4969577d5e Author: maximilian.novikov@db.com <maximilian.novikov@db.com> Date: Wed Jan 13 16:17:25 2021 +0100 Incremental Maven - Java 11 fix commit b2f297566d5afcb0a285985cb5540685a28cafec Author: maximilian.novikov@db.com <maximilian.novikov@db.com> Date: Tue Jan 12 14:10:08 2021 +0100 Incremental Maven - initial commit

….3 to MNG-7129/maven-3.6.3-incremental Squashed commit of the following: commit 21c620a34ddbbf84b3c44014b069a7b222cf91a7 Author: Maximilian Novikov <maximilian.novikov@db.com> Date: Tue Aug 10 19:41:41 2021 +0200 Merge pull request #3 in ABFX/maven-forked from code-cleanup-2 to incremental-maven-3.6.3 Squashed commit of the following: commit 3401739ec9eb957fb03887f6a3c24477c9c3327b Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Tue Aug 10 13:37:13 2021 -0400 cleanup db specifics commit 5d32f00559951445ecaf7d5ec4d847541c10e7e9 Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Tue Aug 10 11:05:28 2021 -0400 cleanup db specifics commit fcec28f82c0d447de64032c610b39fa75bb344b0 Merge: 6fd401af2 5b0dc1858 Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Mon Aug 9 13:22:16 2021 +0100 Pull request apache#9: Remote cache setup Merge in BND/maven-forked from feature/remote-cache-setup to incremental-maven-3.6.3 * commit '5b0dc1858cf4ca499502f0741b2f3bf2ac55530c': remote cache setup - fail fast, baseline build, diff reporting, documentation. commit 5b0dc1858cf4ca499502f0741b2f3bf2ac55530c Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Mon Mar 22 03:30:03 2021 +0100 remote cache setup - fail fast, baseline build, diff reporting, documentation. commit 6fd401af285692df568312ee66ee00edfe21f1cc Author: Maximilian Novikov <maximilian.novikov@db.com> Date: Tue Apr 13 17:36:49 2021 +0100 Pull request apache#8: Incremental Maven - added non-overrideable cache entries Merge in BND/maven-forked from non-overritable-build-info to incremental-maven-3.6.3 Squashed commit of the following: commit 405bbef8a59cabc0b83e9a64717f65fbd6fb9e3d Author: maximilian.novikov@db.com <maximilian.novikov@db.com> Date: Mon Apr 12 20:18:27 2021 +0200 Incremental Maven - added non-overrideable cache entries - review fixes commit 197704672756e558fb3521e16859d0be324044b8 Author: maximilian.novikov@db.com <maximilian.novikov@db.com> Date: Fri Apr 9 11:35:48 2021 +0200 Incremental Maven - added non-overrideable cache entries commit 64c4b1f5cbdf920ad43560f34cc5be56d4557acf Author: Alexander Ashitkin <alexander.ashitkin@db.com> Date: Tue Mar 9 04:10:20 2021 +0100 injected version commit 727e507ae2fd90dce7011f3f1c76eb4969577d5e Author: maximilian.novikov@db.com <maximilian.novikov@db.com> Date: Wed Jan 13 16:17:25 2021 +0100 Incremental Maven - Java 11 fix commit b2f297566d5afcb0a285985cb5540685a28cafec Author: maximilian.novikov@db.com <maximilian.novikov@db.com> Date: Tue Jan 12 14:10:08 2021 +0100 Incremental Maven - initial commit

jira-importer · 2025-07-06T09:10:54Z

Resolve #7889

[MNG-5075] MavenProject.getParent throws undocumented ISE

a465079

jglick closed this Jan 6, 2014

jglick deleted the MavenProject-getParent-MNG-5075 branch March 1, 2018 19:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MNG-5075] MavenProject.getParent throws undocumented ISE#8

[MNG-5075] MavenProject.getParent throws undocumented ISE#8
jglick wants to merge 1 commit intoapache:masterfrom
jglick:MavenProject-getParent-MNG-5075

jglick commented Apr 29, 2013

Uh oh!

jglick commented Apr 29, 2013

Uh oh!

jglick commented Apr 29, 2013

Uh oh!

olamy commented May 2, 2013

Uh oh!

jglick commented May 6, 2013

Uh oh!

jglick commented Jan 6, 2014

Uh oh!

jira-importer commented Jul 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jglick commented Apr 29, 2013

Uh oh!

jglick commented Apr 29, 2013

Uh oh!

jglick commented Apr 29, 2013

Uh oh!

olamy commented May 2, 2013

Uh oh!

jglick commented May 6, 2013

Uh oh!

jglick commented Jan 6, 2014

Uh oh!

jira-importer commented Jul 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants