[MNG-7572] Allow plugin descriptor to require loading extensions#833
Draft
[MNG-7572] Allow plugin descriptor to require loading extensions#833
Conversation
kwin
force-pushed
the
feature/plugin-descriptor-with-extensions
branch
from
f2cf092 to
20fe5ec
Compare
add all plugins to repository which are required for test fix test cases which now require plugin resolving
Member
Author
|
@gnodet Any idea how to make it work with reactor builds which are both building and using the same plugin? That used to work for certain edge cases with the old approach (which only required evaluating the pom.xml). Should we just fall back to pom.xml and log in the case where the artifact is not yet built at the time where the build extensions are being loaded? |
kwin
commented
Jun 10, 2023
| // potentially a plugin with extensions? | ||
| if ( !plugin.isExtensions() && isBuildExtension == Boolean.FALSE ) | ||
| { | ||
| Artifact pluginMainArtifact = resolveExtensionMainArtifact( plugin, repositories, session ); |
Member
Author
There was a problem hiding this comment.
How to deal with exceptions here in case the plugin artifact cannot be found?
|
Resolve #8219 |
slawekjaranowski
added
the
waiting-for-feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] SUMMARY, where you replaceMNG-XXXand
SUMMARYwith the appropriate JIRA issue. Best practice is to use the JIRA issuetitle in the pull request title and in the first line of the commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.