Skip to content

[MNG-7505] Remove ReportingConverter#906

Merged
gnodet merged 3 commits intoapache:masterfrom
gnodet:MNG-7505
Dec 11, 2022
Merged

[MNG-7505] Remove ReportingConverter#906
gnodet merged 3 commits intoapache:masterfrom
gnodet:MNG-7505

Conversation

@gnodet
Copy link
Copy Markdown
Contributor

@gnodet gnodet commented Dec 9, 2022 •
edited
Loading

slawekjaranowski
slawekjaranowski approved these changes Dec 9, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be ...
but we have next workaround for plugin which was released 2017

@gnodet
Copy link
Copy Markdown
Contributor Author

gnodet commented Dec 9, 2022

It can be ...
but we have next workaround for plugin which was released 2017

This old ?
@slawekjaranowski I've updated the PR to get rid of that code completely...

@slawekjaranowski
Copy link
Copy Markdown
Member

slawekjaranowski commented Dec 9, 2022

Now we only move outputDirectory from reporting section to site plugin configuration ...
but also this is not needed - plugin parameter has as default: ${project.reporting.outputDirectory}

@michael-o
Copy link
Copy Markdown
Member

michael-o commented Dec 10, 2022

Will review

michael-o
michael-o reviewed Dec 10, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So basically the "new style" configuration is dead and the <reporting /> section remains?

@slawekjaranowski
Copy link
Copy Markdown
Member

slawekjaranowski commented Dec 10, 2022

So basically the "new style" configuration is dead and the <reporting /> section remains?

it looks like - only reporting from pom should be used
https://maven.apache.org/plugins/maven-site-plugin/examples/configuring-reports.html
https://maven.apache.org/shared/maven-reporting-exec/

@michael-o michael-o self-requested a review December 10, 2022 15:14
@gnodet gnodet merged commit adf89ef into apache:master Dec 11, 2022
@gnodet gnodet self-assigned this Dec 11, 2022
@gnodet gnodet added this to the 4.0.0-alpha-3 milestone Dec 11, 2022
@gnodet gnodet changed the title [MNG-7505] Disable reportPlugins processing if m-site-p >= 3.7.0 is used [MNG-7505] Remove ReportingConverter Dec 12, 2022
@gnodet gnodet mentioned this pull request Jan 4, 2023
Merged
9 tasks
gnodet added a commit to gnodet/maven that referenced this pull request Jan 4, 2023
@gnodet
[MNG-7642] Restore compatibility with flatten-maven-plugin
69f09fe 
Revert "[MNG-7505] Remove ReportingConverter (apache#906)"
This reverts commit adf89ef.
gnodet added a commit that referenced this pull request Jan 9, 2023
@gnodet
[MNG-7642] Restore compatibility with flatten-maven-plugin (#947)
1968951 
Revert "[MNG-7505] Remove ReportingConverter (#906)"
This reverts commit adf89ef.
@gnodet gnodet deleted the MNG-7505 branch January 25, 2023 13:21
@jira-importer
Copy link
Copy Markdown

jira-importer commented Jul 7, 2025

Resolve #9114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-o michael-o michael-o approved these changes

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

Assignees

@gnodet gnodet

Labels

None yet

Projects

None yet

Milestone

4.0.0-alpha-3

Development

Successfully merging this pull request may close these issues.

4 participants

@gnodet @slawekjaranowski @michael-o @jira-importer